Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcimem: init at unstable-2018-08-29 #108267

Merged
merged 1 commit into from Jan 7, 2021
Merged

Conversation

MarcFontaine
Copy link
Contributor

Motivation for this change

This commit adds the pcimem tool.
pcimem is a simple method of reading and writing to memory registers on a PCI card.
Compared to pkgs.devmem2, it does not work on the total memory space
of the machine but restricts access to just one PCI resource.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/os-specific/linux/pcimem/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/pcimem/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/pcimem/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/pcimem/default.nix Outdated Show resolved Hide resolved
@MarcFontaine
Copy link
Contributor Author

@prusnak Thanks for your reviews. I've updated the package as you suggested.

@MarcFontaine MarcFontaine changed the title pcimem: init at 2018-08-29 pcimem: init at unstable-2018-08-29 Jan 2, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108267 run on x86_64-linux 1

1 package built:
  • pcimem

This commit adds the pcimem tool.
pcimem is a simple method of reading and writing to memory registers on a PCI card.
Compared to pkgs.devmem2, it does not work on the total memory space
of the machine but restricts access to just one PCI resource.
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108267 run on x86_64-linux 1

1 package built:
  • pcimem

@SuperSandro2000 SuperSandro2000 merged commit c5ad2c8 into NixOS:master Jan 7, 2021
@MarcFontaine MarcFontaine deleted the pcimem branch January 7, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants