Skip to content

pcloud: 1.8.8 -> 1.8.9 #108214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2021
Merged

pcloud: 1.8.8 -> 1.8.9 #108214

merged 1 commit into from
Jan 3, 2021
+3 −3

Conversation

2chilled
Copy link
Contributor

@2chilled 2chilled commented Jan 2, 2021 •
edited
Loading

Motivation for this change

Latest Bugfixes

Things done

Bump pcloud to latest bugfix version

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested a review from Patryk27 January 2, 2021 11:17
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 2, 2021
Patryk27
Patryk27 suggested changes Jan 2, 2021
View reviewed changes
Copy link
Member

@Patryk27 Patryk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'd have to rename the commit to say pcloud: 1.8.8 -> 1.8.9 (https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes), but other than that - LGTM.

@2chilled
pcloud: 1.8.8 -> 1.8.9

Verified

This commit was signed with the committer’s verified signature.
rasendubi Oleksii Shmalko
GPG key ID: DCEF7BCCEB3066C3
Verified
Learn about vigilant mode
5356935
@ofborg ofborg bot requested a review from Patryk27 January 2, 2021 12:31
@SuperSandro2000 SuperSandro2000 changed the title bump pcloud pcloud: 1.8.8 -> 1.8.9 Jan 2, 2021
@WolfangAukang
Copy link
Contributor

Result of nixpkgs-review pr 108214 run on x86_64-linux 1

1 package built:
  • pcloud

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/321

@SuperSandro2000 SuperSandro2000 merged commit a09ec0d into NixOS:master Jan 3, 2021
@2chilled
Copy link
Contributor Author

2chilled commented Jan 3, 2021

@Patryk27 Within the actual pcloud binary there is a reference to /usr/bin/wget. Unfortunately we cannot easily replace that with a nix path without breaking the binary itself. Maybe there are some tools around for tasks like that, don't know.

@2chilled 2chilled deleted the pcloud_upgrade branch January 3, 2021 18:18
@Patryk27
Copy link
Member

Patryk27 commented Jan 3, 2021

@2chilled when push comes to shove, there's always buildFHSUserEnv (e.g. https://vaibhavsagar.com/blog/2018/03/17/faking-non-nixos-stack/) - I'll try to take a look and see what I can do; do you know where / when pcloud tries to launch wget?

@2chilled
Copy link
Contributor Author

2chilled commented Jan 3, 2021

@Patryk27 cool, thx for the link. I think they call it for uploading crash dumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patryk27 Patryk27

@WolfangAukang WolfangAukang

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@2chilled @WolfangAukang @nixos-discourse @Patryk27 @SuperSandro2000