Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.fern-vim: init at 2020-12-22 #108213

Merged
merged 3 commits into from Jan 5, 2021
Merged

vimPlugins.fern-vim: init at 2020-12-22 #108213

merged 3 commits into from Jan 5, 2021

Conversation

jmc-figueira
Copy link

@jmc-figueira jmc-figueira commented Jan 2, 2021 •
edited

Motivation for this change

Added the fern.vim vim plugin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Please never merge master into a branch to fix a conflict. I am going to fix that now once because I need to add another commit.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108213 run on x86_64-linux 1

27 packages built:
  • spacevim
  • vimPlugins.Spacegray-vim
  • vimPlugins.YouCompleteMe
  • vimPlugins.coc-nvim
  • vimPlugins.completion-nvim
  • vimPlugins.defx-git
  • vimPlugins.deol-nvim
  • vimPlugins.fern-vim
  • vimPlugins.nvim-highlite
  • vimPlugins.nvim-lspconfig
  • vimPlugins.nvim-lsputils
  • vimPlugins.nvim-treesitter
  • vimPlugins.nvim-treesitter-context
  • vimPlugins.nvim-treesitter-textobjects
  • vimPlugins.telescope-nvim
  • vimPlugins.vim-airline
  • vimPlugins.vim-clap
  • vimPlugins.vim-floaterm
  • vimPlugins.vim-hexokinase
  • vimPlugins.vim-lsp
  • vimPlugins.vim-ocaml
  • vimPlugins.vim-polyglot
  • vimPlugins.vim-visual-multi
  • vimPlugins.vim-vsnip
  • vimPlugins.vimsence
  • vimPlugins.vista-vim
  • vimPlugins.yats-vim

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108213 run on x86_64-darwin 1

4 packages built:
  • spacevim
  • vimPlugins.YouCompleteMe
  • vimPlugins.vim-clap
  • vimPlugins.vim-hexokinase

@SuperSandro2000 SuperSandro2000 merged commit 8f78ad9 into NixOS:master Jan 5, 2021
@jmc-figueira
Copy link
Author

Please never merge master into a branch to fix a conflict. I am going to fix that now once because I need to add another commit.

Oh, I'm sorry, I followed this suggestion and thought it would be the ideal way of keeping my branch up to date. I initially tried a rebase, which pulled all of master's recent commits into the pull request, which was definitely a bad idea, so I thought a merge was the right thing to do. For future reference, what is the recommended way of doing this?

In any case, thank you for approving my request.

@jmc-figueira jmc-figueira deleted the fern.vim branch January 5, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@hugolgst hugolgst Awaiting requested review from hugolgst

@jagajaga jagajaga Awaiting requested review from jagajaga

@MarcWeber MarcWeber Awaiting requested review from MarcWeber

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@FRidh FRidh Awaiting requested review from FRidh

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmc-figueira @SuperSandro2000 @Janik-Haag