Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdlib-purple: init at 0.7.6 #108181

Closed
wants to merge 1 commit into from
Closed

tdlib-purple: init at 0.7.6 #108181

wants to merge 1 commit into from

Conversation

Lassulus
Copy link
Member

@Lassulus Lassulus commented Jan 1, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [x Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

currently running this with bitlbee-purple. works better then the old telegram-purple :)

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 2, 2021 •
edited

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108181 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • tdlib-purple

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

tdlib-purple.log:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/networking/instant-messengers/pidgin-plugins/tdlib-purple/default.nix:30:5:

   |
30 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
�[1;33mwarning: missing-phase-hooks�[0m
installPhase should probably contain runHook preInstall and runHook postInstall.

Near pkgs/applications/networking/instant-messengers/pidgin-plugins/tdlib-purple/default.nix:22:3:

   |
22 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

The second comment about installPhase should not be included but right now everything is always included. Working on a fix.

@Lassulus Lassulus force-pushed the tdlib-purple-init branch 2 times, most recently from ec9d61a to eb479d6 Compare January 2, 2021 10:21
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108181 run on x86_64-linux 1

1 package failed to build and are new build failure:

rmcgibbo
rmcgibbo suggested changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@rmcgibbo rmcgibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the build error I see

trace: Warning: `stdenv.lib` is deprecated and will be removed in the next release. Please use `lib` instead. For more information see https://github.com/NixOS/nixpkgs/issues/108938
these 2 derivations will be built:
  /nix/store/k8d9sayfvp19pwh9jdn07ldmsryxf90j-tdlib-purple-0.7.6.drv
  /nix/store/ggqk1rgkp045zr1j7bqd4hqa0a14cv9h-review-shell.drv
building '/nix/store/k8d9sayfvp19pwh9jdn07ldmsryxf90j-tdlib-purple-0.7.6.drv'...
unpacking sources
unpacking sources
unpacking source archive /nix/store/licql3fw5p4yjf8zagq8wd9p9x886vxc-source
unpacking source archive /nix/store/licql3fw5p4yjf8zagq8wd9p9x886vxc-source
source root is source
source root is source
patching sources
patching sources
configuring
configuring
fixing cmake files...
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/share/doc/tdlib-purple -DCMAKE_INSTALL_INFODIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/include -DCMAKE_INSTALL_SBINDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/cp1sa3xxvl71cypiinw2c62i5s33chlr-binutils-2.35.1/bin/strip -DCMAKE_RANLIB=/nix/store/cp1sa3xxvl71cypiinw2c62i5s33chlr-binutils-2.35.1/bin/ranlib -DCMAKE_AR=/nix/store/cp1sa3xxvl71cypiinw2c62i5s33chlr-binutils-2.35.1/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6 -Dtgvoip_INCLUDE_DIRS=/nix/store/m1q8qsrpk5cpvzgjfikkdv7fgz7662lq-libtgvoip-unstable-2020-03-02-dev/include/tgvoip
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/share/doc/tdlib-purple -DCMAKE_INSTALL_INFODIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/include -DCMAKE_INSTALL_SBINDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/cp1sa3xxvl71cypiinw2c62i5s33chlr-binutils-2.35.1/bin/strip -DCMAKE_RANLIB=/nix/store/cp1sa3xxvl71cypiinw2c62i5s33chlr-binutils-2.35.1/bin/ranlib -DCMAKE_AR=/nix/store/cp1sa3xxvl71cypiinw2c62i5s33chlr-binutils-2.35.1/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/smi6cixvrgj5z0ycip3nbapxwda7dnd6-tdlib-purple-0.7.6 -Dtgvoip_INCLUDE_DIRS=/nix/store/m1q8qsrpk5cpvzgjfikkdv7fgz7662lq-libtgvoip-unstable-2020-03-02-dev/include/tgvoip 
-- The CXX compiler identification is GNU 10.2.0
-- The CXX compiler identification is GNU 10.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/ca37d3qrydh0wpw40kswsx30j8dyzxh2-gcc-wrapper-10.2.0/bin/g++ - skipped
-- Check for working CXX compiler: /nix/store/ca37d3qrydh0wpw40kswsx30j8dyzxh2-gcc-wrapper-10.2.0/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:10 (message):
CMake Error at CMakeLists.txt:10 (message):
  tdlib version 1.6.5 or older is required
  tdlib version 1.6.5 or older is required




-- Configuring incomplete, errors occurred!
-- Configuring incomplete, errors occurred!
See also "/build/source/build/CMakeFiles/CMakeOutput.log".
See also "/build/source/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/k8d9sayfvp19pwh9jdn07ldmsryxf90j-tdlib-purple-0.7.6.drv' failed with exit code 1
cannot build derivation '/nix/store/ggqk1rgkp045zr1j7bqd4hqa0a14cv9h-review-shell.drv': 1 dependencies couldn't be built

@Lassulus
Copy link
Member Author

well, not much I can do, since the tdlib version is nixpkgs is to new for this, even in 0.7.8 they want a very old version. so we either need to package tdlib in an old version for this or wait until tdlib-purple is updated to work with the new tdlib version

@Lassulus
Copy link
Member Author

maybe when this will get ready/merged we can continue: ars3niy/tdlib-purple#98

@SuperSandro2000 SuperSandro2000 marked this pull request as draft April 5, 2021 22:33
@stale
Copy link

stale bot commented Oct 12, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 12, 2021
@Lassulus Lassulus closed this Apr 15, 2022
@sikmir sikmir mentioned this pull request Jul 10, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse left review comments

@rmcgibbo rmcgibbo rmcgibbo requested changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lassulus @SuperSandro2000 @rmcgibbo @aanderse