Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clojure: 1.10.1.727 -> 1.10.1.763 #108187

Merged
merged 2 commits into from Jan 5, 2021
Merged

clojure: 1.10.1.727 -> 1.10.1.763 #108187

merged 2 commits into from Jan 5, 2021

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Jan 2, 2021 •
edited

Motivation for this change

Bump Clojure (changelog): https://clojure.org/releases/tools.

Also, add myself as a maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada thiagokokada changed the title Bump clojure clojure: 1.10.1.727 -> 1.10.1.763 Jan 2, 2021
@ofborg ofborg bot requested a review from jlesquembre January 2, 2021 02:29
@thiagokokada
Copy link
Contributor Author

thiagokokada commented Jan 2, 2021 •
edited

Result of nixpkgs-review pr 108187 1

2 packages built:
  • clojure
  • lumo

Tested execution of both clojure and lumo.

jlesquembre
jlesquembre approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@jlesquembre jlesquembre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/322

@thiagokokada
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 4, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 4, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@thiagokokada
Copy link
Contributor Author

thiagokokada commented Jan 4, 2021 •
edited

@jlesquembre can you send a /status needs_merger please, so we can use marvin to get this merged faster?

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 4, 2021

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@jlesquembre
Copy link
Member

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau January 4, 2021 19:18
timokau
timokau approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@timokau timokau merged commit 9dd4dda into NixOS:master Jan 5, 2021
@thiagokokada thiagokokada deleted the bump-clojure branch January 25, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlesquembre jlesquembre jlesquembre approved these changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thiagokokada @nixos-discourse @jlesquembre @timokau