Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wine update #108225

Merged
merged 4 commits into from Jan 14, 2021
Merged

Wine update #108225

merged 4 commits into from Jan 14, 2021

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Jan 2, 2021

Motivation for this change

Regular wineUnstable+staging update to 6.0-rc4 (include intermediate steps)

(wowStaging and 32bit staging tested and works well for me)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kira-bruneau
Copy link
Contributor

Result of nixpkgs-review pr 108225 run on x86_64-linux 1

9 packages built:
  • lutris
  • lutris-free
  • lutris-unwrapped
  • pipelight
  • wine-staging
  • winePackages.staging
  • winePackages.unstable
  • wineWowPackages.staging
  • wineWowPackages.unstable

kira-bruneau
kira-bruneau approved these changes Jan 2, 2021
View reviewed changes
Copy link
Contributor

@kira-bruneau kira-bruneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @avnik! This looks good to me.

@SuperSandro2000
Copy link
Member

diff LGTM

@7c6f434c 7c6f434c merged commit 983cd52 into NixOS:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kira-bruneau kira-bruneau kira-bruneau approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avnik @kira-bruneau @SuperSandro2000 @7c6f434c