Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttyrec: 1.0.8 -> ovh-ttyrec 1.1.6.6 #108182

Merged
merged 1 commit into from Jan 2, 2021
Merged

ttyrec: 1.0.8 -> ovh-ttyrec 1.1.6.6 #108182

merged 1 commit into from Jan 2, 2021

Conversation

charles-dyfis-net
Copy link
Contributor

Motivation for this change

The upstream ttyrec package has been marked broken since January 2020, as it depends on a deprecated POSIX API that Linux has never fully supported, and for which such support as did exist has been withdrawn from glibc.

This PR replaces the broken ttyrec derivation with one packaging an actively-maintained fork by @ovh.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@charles-dyfis-net
Copy link
Contributor Author

charles-dyfis-net commented Jan 2, 2021 •
edited

Items where feedback is requested:

  • Is it okay to take over the ttyrec name when switching source trees, or should this have a new top-level entry?
  • Is @zimbatm okay with remaining on the maintainers list with this change?

@ofborg ofborg bot requested a review from zimbatm January 2, 2021 00:28
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 2, 2021 •
edited

Is it okay to take over the ttyrec name when switching source trees, or should this have a new top-level entry?

The old one had its last release 14 years ago and if it is a drop in replacement I think it is finish.

Is @zimbatm okay with remaining on the maintainers list with this change?

It is broken since almost a year so I think this should be fine.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108182 run on x86_64-darwin 1

1 package built:
  • ttyrec

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108182 run on x86_64-linux 1

1 package built:
  • ttyrec

@zimbatm
Copy link
Member

zimbatm commented Jan 2, 2021

Since the pname has changed, can you please update all-packages.nix to rename the attibute as well? Update ttyrec to ovh-ttyrec and then add an alias back from ttyrec to ovh-ttyrec in pkgs/top-level/aliases.nix

Ideally we want pname and attribute names to match, to simplify reverse-lookup from a store path to attribute. ttyrec can then be kept as

@charles-dyfis-net
ttyrec: 1.0.8 -> ovh-ttyrec 1.1.6.6
ecd1daa 
Replace unmaintained/broken upstream ttyrec with a maintained, compatible fork
@charles-dyfis-net
Copy link
Contributor Author

@zimbatm -- updated per request; ttyrec is now in pkgs/top-level/aliases.nix, whereas pkgs/top-level/all-packages.nix uses the ovh-ttyrec name. I also updated the directory name to match.

zimbatm
zimbatm approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@zimbatm
Copy link
Member

zimbatm commented Jan 2, 2021

Result of nixpkgs-review pr 108182 run on x86_64-linux 1

1 package built:
  • ovh-ttyrec

@zimbatm zimbatm merged commit 854096f into NixOS:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

@lukegb lukegb lukegb approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@charles-dyfis-net @SuperSandro2000 @zimbatm @lukegb