nixos/command-not-found: don't suggest nix-env #108184
Merged
+8
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It's well documented, and evident to anyone who spends any amount of time
helping people on IRC, that
nix-env
is a huge foot-gun. In an effort to limitbeginners exposure to this, I think we should not let
command-not-found
suggest it, and instead tell people to use
nix-shell
.This should help avoid a lot of frustration for beginners and save those who
provide support on IRC from diagnosing
nix-env
misuse constantly.cc. @grahamc
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)