Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/command-not-found: don't suggest nix-env #108184

Merged
merged 2 commits into from Jan 2, 2021
Merged

nixos/command-not-found: don't suggest nix-env #108184

merged 2 commits into from Jan 2, 2021

Conversation

lovesegfault
Copy link
Member

Motivation for this change

It's well documented, and evident to anyone who spends any amount of time
helping people on IRC, that nix-env is a huge foot-gun. In an effort to limit
beginners exposure to this, I think we should not let command-not-found
suggest it, and instead tell people to use nix-shell.

This should help avoid a lot of frustration for beginners and save those who
provide support on IRC from diagnosing nix-env misuse constantly.

cc. @grahamc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Jan 2, 2021

nix-shell has its own footguns as well, such as adding a whole bunch of environment variables which come from the build environment.

But I agree, nix-env is worse, and considering nix-shell is the tool we promote on nixos.org for exactly that purpose, it's probably more suitable.

@flokli flokli merged commit 71e2436 into NixOS:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@grahamc grahamc Awaiting requested review from grahamc

@flokli flokli Awaiting requested review from flokli

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lovesegfault @flokli @bjornfor @SuperSandro2000