Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.esy: init at 0.6.7 #108178

Closed
wants to merge 1 commit into from
Closed

nodePackages.esy: init at 0.6.7 #108178

wants to merge 1 commit into from

Conversation

jakeisnt
Copy link

@jakeisnt jakeisnt commented Jan 1, 2021

Motivation for this change

Adding the esy package is one step towards integrating the esy package manager with Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested by building with Node.

@jakeisnt
Copy link
Author

jakeisnt commented Jan 1, 2021

I'm not sure where the util-linux -> utillinux change came from; I can revert that as necessary if it's not part of the process. I just followed the documentation for adding an NPM package to nixpkgs.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 2, 2021 •
edited

I'm not sure where the util-linux -> utillinux change came from; I can revert that as necessary if it's not part of the process. I just followed the documentation for adding an NPM package to nixpkgs.

it comes from node2nix. Maybe we need to bump it in nixpkgs to fix svanderburg/node2nix#213. Please revert it. Also I am probably going to take your PR and merge it with two other nodePackages updates.

@jakeisnt
Copy link
Author

jakeisnt commented Jan 2, 2021

I'm not sure where the util-linux -> utillinux change came from; I can revert that as necessary if it's not part of the process. I just followed the documentation for adding an NPM package to nixpkgs.

it comes from node2nix. Maybe we need to bump it in nixpkgs to fix svanderburg/node2nix#213. Please revert it. Also I am probably going to take your PR and merge it with two other nodePackages updates.

Done! That sounds great, feel free to do so.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 2, 2021 •
edited

PR got combined with a few other node updates. Closing so that the update goes trough smoothly.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 2, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakeisnt @SuperSandro2000