Fix: [OSX] Register fonts loaded directly from disk for text layout #8484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michicc
force-pushed
the
pr/osx_font_reg
branch
from
9515d61
to
0a191ac
Compare
…th CoreText for proper text layout.
michicc
force-pushed
the
pr/osx_font_reg
branch
from
0a191ac
to
99d5fe7
Compare
LordAro
approved these changes
Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Unicode text layout on OSX is done by CoreText, which only uses font data registered with CoreText.
Description
Register font that are loaded from file and not the OS store with CoreText.
Limitations
Interacts with #8482.FreeType and OSX CoreText might still not agree pixel-perfect.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.