go_2-dev: change pname/version to use unstable format #108270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise this causes problems with stable go versions and nix-env
10 tasks
mdlayher
reviewed
Jan 3, 2021
There was a problem hiding this comment.
The change seems reasonable but this appears not to bootstrap in the PR review environment (at least here):
$ nixpkgs-review pr 108270
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/108270/head:refs/nixpkgs-review/1
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Total 7 (delta 6), reused 6 (delta 6), pack-reused 1
Unpacking objects: 100% (7/7), 642 bytes | 321.00 KiB/s, done.
From ssh://github.com/NixOS/nixpkgs
+ a1e9a94785c...2e7ccd2c2c9 refs/pull/108270/head -> refs/nixpkgs-review/1 (forced update)
$ git worktree add /home/matt/.cache/nixpkgs-review/pr-108270/nixpkgs 712830d101d94ae29a2310d91b4d54c0132f5716
Preparing worktree (detached HEAD 712830d101d)
HEAD is now at 712830d101d Merge pull request #108310 from mdlayher/mdl-bump-corerad
$ git merge --no-commit 2e7ccd2c2c929b05172a33d685b8635211e33eee
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/matt/.cache/nixpkgs-review/pr-108270/build.nix
builder for '/nix/store/2yyzgpc9yiv0fkn1qx97naghv99bkh2g-go2-unstable-2020-12-08.drv' failed with exit code 1; last 10 log lines:
ok cmd/link/internal/loader 0.091s
ok cmd/link/internal/sym 0.083s
ok cmd/nm 2.760s
ok cmd/objdump 1.792s
ok cmd/oldlink/internal/sym 0.052s
ok cmd/pack 0.940s
ok cmd/trace 0.078s
ok cmd/vet 4.452s
FAIL
go tool dist: Failed: exit status 1
cannot build derivation '/nix/store/j6xd9pyc8i711h3yzv158w6fjs14ykrd-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 6 copied (379.7 MiB), 61.2 MiB DL]
error: build of '/nix/store/j6xd9pyc8i711h3yzv158w6fjs14ykrd-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/108270
1 package failed to build:
go_2-dev
|
ofborg doesn't seem to like it either, failed on x86_64-linux here and the original PR. aarch64-linux on ofborg is fine, builds locally on x86_64-nixos. |
kalbasit
approved these changes
Jan 3, 2021
|
Thanks for doing this! After this is merged I'm still getting upgraded from go-1.15.6 to g-2: Is there anything else I need to do (or maybe wait for some other release from nixpkgs-channels repo)? |
|
Just need to wait for the channels to update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise this causes problems with stable go versions and nix-env
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)