Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.Pyro4: Fix hanging tests on darwin #108269

Merged
merged 1 commit into from Jan 3, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 2, 2021
@SuperSandro2000 SuperSandro2000 marked this pull request as draft January 2, 2021 23:22
@ofborg ofborg bot requested a review from prusnak January 2, 2021 23:31
@prusnak
Copy link
Member

prusnak commented Jan 3, 2021

The __darwinAllowLocalNetworking = true; trick worked on my machine

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 108269 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • python37Packages.flower
  • python38Packages.flower
13 packages failed to build:
  • octoprint
  • python38Packages.alerta-server
  • python38Packages.sentry-sdk
  • sourcehut.buildsrht
  • sourcehut.dispatchsrht
  • sourcehut.gitsrht
  • sourcehut.hgsrht
  • sourcehut.hubsrht
  • sourcehut.listssrht
  • sourcehut.mansrht
  • sourcehut.metasrht
  • sourcehut.pastesrht
  • sourcehut.todosrht
14 packages built:
  • python37Packages.Pyro4
  • python37Packages.alerta-server
  • python37Packages.celery
  • python37Packages.django-raster
  • python37Packages.djmail
  • python37Packages.kombu
  • python37Packages.sentry-sdk
  • python38Packages.Pyro4
  • python38Packages.celery
  • python38Packages.django-raster
  • python38Packages.djmail
  • python38Packages.kombu
  • python39Packages.Pyro4
  • python39Packages.kombu

The other build failures are unrelated to this PR and I am fixing them in another one.

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review January 3, 2021 05:39
@SuperSandro2000 SuperSandro2000 merged commit ed6af93 into NixOS:master Jan 3, 2021
@SuperSandro2000 SuperSandro2000 deleted the pyro3-darwin branch January 3, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants