Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manual/gnome: clarify the glib setup hook #108218

Closed
wants to merge 1 commit into from
Closed

manual/gnome: clarify the glib setup hook #108218

wants to merge 1 commit into from

Conversation

raboof
Copy link
Member

@raboof raboof commented Jan 2, 2021

Clarify loading the glib setup hook is not done automatically,
so to add the gsettings schema's to the XDG_DATA_DIRS you
will have to load it explicitly (like in
#108216)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof
nixpkgs manual/gnome: clarify the glib setup hook
a8341ce 
Clarify loading the glib setup hook is not done automatically,
so to add the gsettings schema's to the XDG_DATA_DIRS you
will have to load it explicitly (like in
NixOS#108216)
@SuperSandro2000 SuperSandro2000 changed the title nixpkgs manual/gnome: clarify the glib setup hook manual/gnome: clarify the glib setup hook Jan 2, 2021
SuperSandro2000
SuperSandro2000 requested changes Jan 2, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message title to manual/gnome: clarify the glib setup hook.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 2, 2021

The fact that the other setup hooks are not added automatically is true for all the setup hooks in the list and it is hinted by “It works in conjunction with other setup hooks that populate environment variables”. Previously, this statement with a colon directly preceded the list but it got less clear in acfc45b#diff-f9526e8695d8507478b5271f99ff90e2a49a40ce1209615ad622223a0bce2289

@raboof
Copy link
Member Author

raboof commented Jan 4, 2021

true for all the setup hooks in the list

Ah, I didn't notice. I think we should make this more clear again, but indeed this PR doesn't make sense in its current form.

@raboof raboof closed this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @jtojnar @SuperSandro2000