Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ft2-clone: 1.41_fix -> 1.42, fix darwin #108167

Merged
merged 2 commits into from Jan 11, 2021
Merged

ft2-clone: 1.41_fix -> 1.42, fix darwin #108167

merged 2 commits into from Jan 11, 2021

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jan 1, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108167 run on x86_64-linux 1

1 package built:
  • ft2-clone

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108167 run on x86_64-darwin 1

1 package failed to build:
  • ft2-clone
/tmp/nix-build-ft2-clone-1.42.drv-0/source/src/rtmidi/RtMidi.cpp:1479:10: fatal error: 'alsa/asoundlib.h' file not found
#include <alsa/asoundlib.h>
         ^~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/ft2-clone.dir/build.make:784: CMakeFiles/ft2-clone.dir/src/rtmidi/RtMidi.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:95: CMakeFiles/ft2-clone.dir/all] Error 2
make: *** [Makefile:149: all] Error 2

@fgaz
Copy link
Member Author

fgaz commented Jan 2, 2021

@SuperSandro2000 not a regression, but if you have the time to test some fix commits we can try to make it build

@fgaz
Copy link
Member Author

fgaz commented Jan 2, 2021

@SuperSandro2000 okay, this should fix it. I tested it on a darwin github action, so it should build.

@fgaz fgaz changed the title ft2-clone: 1.41_fix -> 1.42 ft2-clone: 1.41_fix -> 1.42, fix darwin Jan 2, 2021
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 2, 2021
@fgaz fgaz mentioned this pull request Jan 2, 2021
Open
85 tasks
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108167 run on x86_64-darwin 1

1 package built:
  • ft2-clone

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108167 run on x86_64-linux 1

1 package built:
  • ft2-clone

@SuperSandro2000 SuperSandro2000 merged commit f4017bf into NixOS:master Jan 11, 2021
@fgaz fgaz deleted the ft2-clone/1.42 branch January 11, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @SuperSandro2000