Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.connect-box: init at 0.2.8 #108169

Merged
merged 1 commit into from Jan 2, 2021
Merged

python3Packages.connect-box: init at 0.2.8 #108169

merged 1 commit into from Jan 2, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 1, 2021

Motivation for this change

Python Client for interacting with the cable modem/router Compal CH7465LG which
is provided under different names by various ISP in Europe.

  • UPC Connect Box (CH)
  • Irish Virgin Media Super Hub 3.0 (IE)
  • Ziggo Connectbox (NL)
  • Unitymedia Connect Box (DE)

https://github.com/home-assistant-ecosystem/python-connect-box

This is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108169 run on x86_64-linux 1

3 packages built:
  • python37Packages.connect-box
  • python38Packages.connect-box
  • python39Packages.connect-box

@prusnak
Copy link
Member

prusnak commented Jan 2, 2021

@GrahamcOfBorg build python3Packages.connect-box

@prusnak prusnak merged commit 2316f54 into NixOS:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @SuperSandro2000 @prusnak