Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates #108261

Merged
merged 5 commits into from Jan 4, 2021
Merged

Updates #108261

merged 5 commits into from Jan 4, 2021

Conversation

AndersonTorres
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from spacefrogg January 2, 2021 23:28
@otavio
Copy link
Contributor

otavio commented Jan 3, 2021

This triggers a huge number of rebuilds, please target staging in this case.

otavio
otavio suggested changes Jan 3, 2021
View reviewed changes
Copy link
Contributor

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The first commit need some love and while on that, would you be willing to add auto-update support?

Maybe:

  passthru = {
    updateScript = nix-update-script {
      attrPath = pname;
    };
  };

On the nix files do the trick.

pkgs/development/libraries/slang/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

/rebase-staging

@github-actions github-actions bot changed the base branch from master to staging January 3, 2021 08:35
@AndersonTorres
Copy link
Member Author

@SuperSandro2000 is everything OK?

@otavio
Copy link
Contributor

otavio commented Jan 4, 2021

The joe commit has not been split. So for me it is still a NACK.

@AndersonTorres
Copy link
Member Author

@otavio done

@AndersonTorres AndersonTorres merged commit a5c8483 into NixOS:staging Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@otavio otavio otavio approved these changes

@spacefrogg spacefrogg Awaiting requested review from spacefrogg

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndersonTorres @otavio @SuperSandro2000