Skip to content

ttygif: add missing dependencies on xwd, imagemagick #108260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2021
Merged

ttygif: add missing dependencies on xwd, imagemagick #108260

merged 1 commit into from
Jan 4, 2021
+7 −1

Conversation

charles-dyfis-net
Copy link
Contributor

Motivation for this change

As currently packaged, ttygif can fail at execution time due to being unable to find the convert command (from ImageMagick), or the xwd command (from xorg, used to take screenshots).

This PR wraps the executable, adding the dependencies to the PATH.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

moaxcp
moaxcp approved these changes Jan 3, 2021
View reviewed changes
Copy link
Contributor

@moaxcp moaxcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

SuperSandro2000
SuperSandro2000 reviewed Jan 3, 2021
View reviewed changes
@charles-dyfis-net
ttygif: add missing dependencies on xwd, imagemagick

Verified

This commit was signed with the committer’s verified signature.
SuperSandro2000 Sandro
GPG key ID: 3AF5A43A3EECC2E5
Verified
Learn about vigilant mode
0d758e6
@ofborg ofborg bot requested a review from moaxcp January 3, 2021 16:36
@charles-dyfis-net
Copy link
Contributor Author

@SuperSandro2000, updated per suggestion, thank you.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108260 run on x86_64-darwin 1

1 package built:
  • ttygif

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108260 run on x86_64-linux 1

1 package built:
  • ttygif

@SuperSandro2000 SuperSandro2000 merged commit 00dc9ff into NixOS:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

@moaxcp moaxcp

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charles-dyfis-net @SuperSandro2000 @moaxcp