signumone-ks: init at 3.1.2 #108191
Merged
signumone-ks: init at 3.1.2 #108191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
SuperSandro2000
requested changes
Jan 2, 2021
| installPhase = '' | ||
| DESKTOP_PATH=$out/share/applications/signumone-ks.desktop | ||
|
|
||
| mkdir -p $out/{bin,share/applications} |
There was a problem hiding this comment.
Suggested change
| mkdir -p $out/{bin,share/applications} | |
| mkdir -p $out/bin $out/share/applications |
| mv opt/SignumOne-KS/SignumOne-KS.desktop $DESKTOP_PATH | ||
| mv opt $out | ||
|
|
||
| sed -e "s|\(Exec=\)/opt/SignumOne-KS|\1$out/bin|g" -i $DESKTOP_PATH |
There was a problem hiding this comment.
Please use substituteInPlace.
There was a problem hiding this comment.
Done in force-pushed commit
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or torch) Result of 1 package built:
|
WolfangAukang
force-pushed
the
signumone-ks-init
branch
from
730065e
to
17fafad
Compare
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
dotlambda
reviewed
Feb 2, 2021
|
|
||
| buildInputs = [ | ||
| atk glibc gdk-pixbuf stdenv.cc.cc ffmpeg | ||
| libav_0_8 gtk3 libXtst |
There was a problem hiding this comment.
I doubt we need both ffmpeg and libav_0_8.
Also, shouldn't glibc and stdenv.cc.cc automatically be added by stdenv.mkDerivation?
There was a problem hiding this comment.
Not adding libav_0_8 will not build.
autoPatchelfHook could not satisfy dependency libavcodec-ffmpeg.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so
autoPatchelfHook could not satisfy dependency libavcodec.so.53 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-53.so
autoPatchelfHook could not satisfy dependency libavcodec.so.57 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so
autoPatchelfHook could not satisfy dependency libavcodec.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-56.so
autoPatchelfHook could not satisfy dependency libavcodec.so.55 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-55.so
autoPatchelfHook could not satisfy dependency libavcodec.so.54 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-54.so
autoPatchelfHook could not satisfy dependency libavformat-ffmpeg.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so
autoPatchelfHook could not satisfy dependency libavformat.so.54 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-54.so
autoPatchelfHook could not satisfy dependency libavformat.so.55 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-55.so
autoPatchelfHook could not satisfy dependency libavformat.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-56.so
autoPatchelfHook could not satisfy dependency libavformat.so.57 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so
autoPatchelfHook could not satisfy dependency libavformat.so.53 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-53.so
/nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3
There was a problem hiding this comment.
Never mind, I forgot that it is ignoring missing deps. It is running as expected. Going to fix it.
There was a problem hiding this comment.
Not adding
libav_0_8will not build.autoPatchelfHook could not satisfy dependency libavcodec-ffmpeg.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so autoPatchelfHook could not satisfy dependency libavcodec.so.53 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-53.so autoPatchelfHook could not satisfy dependency libavcodec.so.57 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so autoPatchelfHook could not satisfy dependency libavcodec.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-56.so autoPatchelfHook could not satisfy dependency libavcodec.so.55 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-55.so autoPatchelfHook could not satisfy dependency libavcodec.so.54 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-54.so autoPatchelfHook could not satisfy dependency libavformat-ffmpeg.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so autoPatchelfHook could not satisfy dependency libavformat.so.54 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-54.so autoPatchelfHook could not satisfy dependency libavformat.so.55 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-55.so autoPatchelfHook could not satisfy dependency libavformat.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-56.so autoPatchelfHook could not satisfy dependency libavformat.so.57 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so autoPatchelfHook could not satisfy dependency libavformat.so.53 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-53.so /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3
This probably means it requires libav_0_8, but not ffmpeg.
There was a problem hiding this comment.
Actually, you should be fine with ffmpeg_3:
$ nix-build -A ffmpeg_3
$ ls result/lib
libavcodec.so libavfilter.so.6 libavresample.so.3.7.0 libswresample.so
libavcodec.so.57 libavfilter.so.6.107.100 libavutil.so libswresample.so.2
libavcodec.so.57.107.100 libavformat.so libavutil.so.55 libswresample.so.2.9.100
libavdevice.so libavformat.so.57 libavutil.so.55.78.100 libswscale.so
libavdevice.so.57 libavformat.so.57.83.100 libpostproc.so libswscale.so.4
libavdevice.so.57.10.100 libavresample.so libpostproc.so.54 libswscale.so.4.8.100
libavfilter.so libavresample.so.3 libpostproc.so.54.7.100
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)