Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulseaudio: fix cross-compilation #108174

Merged
merged 2 commits into from Jan 1, 2021
Merged

pulseaudio: fix cross-compilation #108174

merged 2 commits into from Jan 1, 2021

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 1, 2021

Motivation for this change

Cross-compile NixOS with pulseaudio.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
alsa-plugins: don't build with libjack2 support when cross-compiling
033cfcc 
libjack2 doesn't cross-compile, see
NixOS#96548.

The pulseaudio NixOS module uses pkgs.alsaPlugins to create its
asound.conf, so let's make sure that one can be built when
cross-compiling.
@flokli
pulseaudio: fix cross compilation by disabling gsettings when cross-c…
767252d 
…ompiling

When cross-compiling, pulseaudio seems to not find some m4 macro
providing GSETTINGS_RULES.

However, apart from the obviously missing gsettings support, this works
just fine.
@flokli flokli added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Jan 1, 2021
@Ericson2314 Ericson2314 merged commit 040d758 into NixOS:staging-next Jan 1, 2021
@flokli flokli deleted the cross-compile-pulseaudio branch January 2, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr Awaiting requested review from samueldr

@jtojnar jtojnar Awaiting requested review from jtojnar

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @Ericson2314