samba4: Properly use Python 3 and fix PYTHONPATH #108177
Closed
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tools (especially AD tools) don't work without dnspython and tdb. This change adds them to $PYTHONPATH. Also this PR fixes the ugly Python 3 override. To test this, it's not enough to just build the package, but you should rather try a tool (like samba_dnsupdate) which is built on Python. If it does not return an ImportError, this change worked.
|
@dasJ Did you find another way to do this? I tried your solution in #105486 (comment) and it works, but I am running on ARM and recompiling on every new Samba version is not feasible. Since samba-tool crashes without these changes, I think something needs fixing in the package right? |
|
Well I'm overlaying and building it every time it changes 🤷 |
|
Ok - thank you for replying so quickly. Would you consider reopening this? :) Or if you do not feel like it is important enough or have the time, would you mind me opening a new pull request with these changes (crediting you of course)? I am also trying to provision a domain, but simply running |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tools (especially AD tools) don't work without dnspython and tdb.
This change adds them to $PYTHONPATH.
Also this PR fixes the ugly Python 3 override.
To test this, it's not enough to just build the package, but you should
rather try a tool (like samba_dnsupdate) which is built on Python. If it
does not return an ImportError, this change worked.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)