Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicity: 0.8.15 -> 0.8.17 #108176

Merged
merged 1 commit into from Jan 31, 2021
Merged

duplicity: 0.8.15 -> 0.8.17 #108176

merged 1 commit into from Jan 31, 2021

Conversation

StephenWithPH
Copy link
Contributor

Motivation for this change

Updates duplicity to current stable 0.8 release 0.8.17, released November 11, 2020.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108176 run on x86_64-linux 1

3 packages built:
  • deja-dup
  • duplicity
  • duply

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

duply.log:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/tools/backup/duply/default.nix:36:5:

   |
36 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
�[1;33mwarning: missing-phase-hooks�[0m
installPhase should probably contain runHook preInstall and runHook postInstall.

Near pkgs/tools/backup/duply/default.nix:18:3:

   |
18 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 108176 run on x86_64-linux 1

3 packages built:
  • deja-dup
  • duplicity
  • duply

@SuperSandro2000 SuperSandro2000 merged commit 4f93b4c into NixOS:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StephenWithPH @SuperSandro2000 @tomberek