Fix #4234, send build logs to Nix 2.3 #4418
Conversation
The conditional on clientVersion isn't accurate for a certain range of master commits, but those are unsupported anyway. It's not accurate for repeated builds either, because that would complicate the code for too little gain.
roberth
changed the title
|
@edolstra could you have a look? |
@Rahul75-dev this makes no sense at all. Please delete it or I'll have to report this as spam. |
|
We should increment the protocol version after this is merged, for 2.3-based clients that want to support a wide range of daemon versions correctly. I would do it myself in this PR, but it's already been three months, so it will probably just cause merge conflicts. :( |
|
I marked this as stale due to inactivity. → More info |
|
Personally, I would actually prefer for the behavior of all nix-daemon versions to remain as simple and predictable as possible. You could focus on other important things that remain relevant in the long term / after the upgrade. |
Fixes #4234 introduced in #3073
Sends build logs to clients in the extra way that Nix 2.3 clients expects to receive.
The conditional on clientVersion isn't accurate for a certain
range of master commits, but those are unsupported anyway.
It's not accurate for repeated builds either, because that
would complicate the code for too little gain.
@ regnat this is one possible solution. If you have another solution that is perhaps more in line with #3073, we could go with that instead.It changed the way the build logs are treated internally, affecting the log messages on the socket. This PR supplements the log to be compatible with 2.3. I don't think there's much else to it.