Skip to content

coreboot-utils: 4.12 -> 4.13 #108254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from Jan 2, 2021
Merged

coreboot-utils: 4.12 -> 4.13 #108254

1 commit merged into from Jan 2, 2021
+3 −3

Conversation

ghost
Copy link

@ghost ghost commented Jan 2, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jan 2, 2021
SuperSandro2000
SuperSandro2000 requested changes Jan 2, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the editor check:

pkgs/tools/misc/coreboot-utils/default.nix:
	92: Trailing whitespace

coreboot-utils: 4.12 -> 4.13

Verified

This commit was signed with the committer’s verified signature.
RobinMalfait Robin Malfait
GPG key ID: 92F53D68B9041AFE
Verified
Learn about vigilant mode
d1cbe7d
@ghost
Copy link
Author

ghost commented Jan 2, 2021

Please fix the editor check:

pkgs/tools/misc/coreboot-utils/default.nix:
	92: Trailing whitespace

As you wish, done!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108254 run on x86_64-linux 1

12 packages built:
  • acpidump-all
  • amdfwtool
  • cbfstool
  • cbmem
  • coreboot-utils
  • ectool
  • ifdtool
  • intelmetool
  • inteltool
  • msrtool
  • nvramtool
  • superiotool

@ghost ghost merged commit 3b7d783 into NixOS:master Jan 2, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SuperSandro2000