Skip to content

python3Packages.pep517: 0.8.2 -> 0.9.1 #108255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2021
Merged

python3Packages.pep517: 0.8.2 -> 0.9.1 #108255

merged 1 commit into from
Jan 3, 2021
+2 −2

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 2, 2021

Motivation for this change

Update to latest upstream release 0.9.1

Commit log: https://github.com/pypa/pep517/commits/master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@fabaff fabaff requested review from FRidh and jonringer as code owners January 2, 2021 19:45
@fabaff fabaff mentioned this pull request Jan 2, 2021
Merged
10 tasks
@prusnak
Copy link
Member

prusnak commented Jan 2, 2021

Can you target this against the staging branch please?

@fabaff fabaff changed the base branch from master to staging January 2, 2021 20:06
@ofborg ofborg bot added 6.topic: emacs Text editor 6.topic: erlang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 2, 2021
@fabaff fabaff changed the base branch from staging to master January 2, 2021 20:12
@ofborg ofborg bot removed 6.topic: emacs Text editor 6.topic: erlang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 2, 2021
@SuperSandro2000
Copy link
Member

/rebase-staging

@SuperSandro2000
Copy link
Member

Can you target this against the staging branch please?

We now have a fancy command I used above that does not notify all code owners but it takes ca. ~3 minutes to run.

@github-actions github-actions bot changed the base branch from master to staging January 2, 2021 20:20
prusnak
prusnak approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested, changes looks fine

@SuperSandro2000
Copy link
Member

Currently building python38Packages.pep517.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108255 run on x86_64-linux 1

1 package built:
  • python38Packages.pep517

@SuperSandro2000 SuperSandro2000 merged commit 3c9adde into NixOS:staging Jan 3, 2021
@fabaff fabaff deleted the bump-pep517 branch January 23, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak

@FRidh FRidh

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Staging
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @prusnak @SuperSandro2000