Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ambiclimate: init at 0.2.1 #108233

Merged
merged 1 commit into from Jan 2, 2021
Merged

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 2, 2021

Motivation for this change

Python library to communicate with ambiclimate.

https://github.com/Danielhiversen/pyAmbiclimate

This is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Jan 2, 2021

Result of nixpkgs-review pr 108233 1

3 packages built:
  • python37Packages.ambiclimate
  • python38Packages.ambiclimate
  • python39Packages.ambiclimate

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, I have one tiny request, that seems to have not been mentioned on your previous contributions ot the home-assistant package over here.

@@ -25,7 +25,7 @@
"almond" = ps: with ps; [ aiohttp-cors ]; # missing inputs: pyalmond
"alpha_vantage" = ps: with ps; [ ]; # missing inputs: alpha_vantage
"amazon_polly" = ps: with ps; [ boto3 ];
"ambiclimate" = ps: with ps; [ aiohttp-cors ]; # missing inputs: ambiclimate
"ambiclimate" = ps: with ps; [ aiohttp-cors ambiclimate ];
Copy link
Member

@mweinelt mweinelt Jan 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this into a separate commit as you are modifying the home-assistant package.

I'm a bit torn here, since reverting it separately is probably not too helpful, it's just how I've had it seen done in the past and it made sense to me to separate it like that.

@mweinelt mweinelt merged commit d47eae3 into NixOS:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants