Skip to content

catboost: init at 0.24.4 #108186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2021
Merged

catboost: init at 0.24.4 #108186

merged 2 commits into from
Jan 20, 2021
+245 −0

Conversation

PlushBeaver
Copy link
Contributor

@PlushBeaver PlushBeaver commented Jan 2, 2021 •
edited by SuperSandro2000
Loading

Motivation for this change
  • Closes Catboost #74395
  • Personal interest in decision trees with categorical features.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Tested examples from CatBoost tutorial.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 2, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Jan 2, 2021
SuperSandro2000
SuperSandro2000 reviewed Jan 2, 2021
View reviewed changes
@roberth
Copy link
Member

roberth commented Jan 19, 2021

@GrahamcOfBorg build pythonPackages.catboost

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108186 run on x86_64-linux 1

2 packages built:
  • python37Packages.catboost
  • python38Packages.catboost

@SuperSandro2000 SuperSandro2000 merged commit 476cb1a into NixOS:master Jan 20, 2021
SuperSandro2000
SuperSandro2000 reviewed May 11, 2022
View reviewed changes
pkgs/development/python-modules/catboost/default.nix
@@ -0,0 +1,56 @@
{ buildPythonPackage, fetchFromGitHub, fetchpatch, lib, pythonOlder
, clang_7, python2
Copy link
Member

@SuperSandro2000 SuperSandro2000 May 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have been drunk when merging this. We can't use python2 or python3 as inputs in pythonPackages or at least need to be very careful with it. Can we somehow get rid of python2 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream scripts invoked during the build of native modules are python2-only. I don't think that upstream developers are willing to upgrade them because CatBoost still supports Python 2 installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

@FRidh FRidh

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Catboost
3 participants
@PlushBeaver @roberth @SuperSandro2000