Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_zen: 5.10.1 -> 5.10.4 #108239

Closed
wants to merge 1 commit into from
Closed

Conversation

andresilva
Copy link
Member

@andresilva andresilva commented Jan 2, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andresilva andresilva requested a review from Atemu January 2, 2021 17:15
@andresilva
Copy link
Member Author

Result of nixpkgs-review pr 108239 run on x86_64-linux 1

8 packages marked as broken and skipped:
  • linuxPackages_zen.ixgbevf
  • linuxPackages_zen.lttng-modules
  • linuxPackages_zen.ndiswrapper
  • linuxPackages_zen.nvidia_x11_legacy304
  • linuxPackages_zen.phc-intel
  • linuxPackages_zen.rtl8723bs
  • linuxPackages_zen.sch_cake
  • linuxPackages_zen.tbs
22 packages failed to build:
  • linuxPackages_zen.akvcam
  • linuxPackages_zen.amdgpu-pro
  • linuxPackages_zen.anbox
  • linuxPackages_zen.chipsec
  • linuxPackages_zen.cryptodev
  • linuxPackages_zen.dpdk
  • linuxPackages_zen.ena
  • linuxPackages_zen.mwprocapture
  • linuxPackages_zen.mxu11x0
  • linuxPackages_zen.nvidia_x11_legacy340
  • linuxPackages_zen.nvidia_x11_legacy390
  • linuxPackages_zen.oci-seccomp-bpf-hook
  • linuxPackages_zen.rtl8192eu
  • linuxPackages_zen.rtl8812au
  • linuxPackages_zen.rtl8814au
  • linuxPackages_zen.rtl8821au
  • linuxPackages_zen.rtl8821ce
  • linuxPackages_zen.rtl88x2bu
  • linuxPackages_zen.rtl88xxau-aircrack
  • linuxPackages_zen.rtlwifi_new
  • linuxPackages_zen.virtualbox
  • linuxPackages_zen.virtualboxGuestAdditions
51 packages built:
  • linuxPackages_zen.acpi_call
  • linuxPackages_zen.asus-wmi-sensors
  • linuxPackages_zen.batman_adv
  • linuxPackages_zen.bbswitch
  • linuxPackages_zen.bcc
  • linuxPackages_zen.bpftrace
  • linuxPackages_zen.broadcom_sta
  • linuxPackages_zen.can-isotp
  • linuxPackages_zen.cpupower
  • linuxPackages_zen.ddcci-driver
  • linuxPackages_zen.digimend
  • linuxPackages_zen.evdi
  • linuxPackages_zen.facetimehd
  • linuxPackages_zen.fwts-efi-runtime
  • linuxPackages_zen.gcadapter-oc-kmod
  • linuxPackages_zen.hyperv-daemons
  • linuxPackages_zen.intel-speed-select
  • linuxPackages_zen.it87
  • linuxPackages_zen.jool
  • linux_zen (linuxPackages_zen.kernel)
  • linuxPackages_zen.mba6x_bl
  • linuxPackages_zen.netatop
  • linuxPackages_zen.nvidia_x11
  • linuxPackages_zen.nvidia_x11_beta
  • linuxPackages_zen.nvidia_x11_vulkan_beta
  • linuxPackages_zen.nvidiabl
  • linuxPackages_zen.openafs (linuxPackages_zen.openafs_1_8)
  • linuxPackages_zen.openafs_1_9
  • linuxPackages_zen.openrazer
  • linuxPackages_zen.perf
  • linuxPackages_zen.ply
  • linuxPackages_zen.r8125
  • linuxPackages_zen.r8168
  • linuxPackages_zen.rtl8821cu
  • linuxPackages_zen.sysdig
  • linuxPackages_zen.system76
  • linuxPackages_zen.system76-acpi
  • linuxPackages_zen.system76-io
  • linuxPackages_zen.systemtap
  • linuxPackages_zen.tmon
  • linuxPackages_zen.tp_smapi
  • linuxPackages_zen.turbostat
  • linuxPackages_zen.tuxedo-keyboard
  • linuxPackages_zen.usbip
  • linuxPackages_zen.v4l2loopback
  • linuxPackages_zen.v86d
  • linuxPackages_zen.vhba
  • linuxPackages_zen.x86_energy_perf_policy
  • linuxPackages_zen.xpadneo
  • linuxPackages_zen.zenpower
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable ,linuxPackages_zen.zfsUnstable)

@andresilva
Copy link
Member Author

☝️ Seems slightly better than #107003.

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 2, 2021

Result of nixpkgs-review pr 108239 1

8 packages marked as broken and skipped:
  • linuxPackages_zen.ixgbevf
  • linuxPackages_zen.lttng-modules
  • linuxPackages_zen.ndiswrapper
  • linuxPackages_zen.nvidia_x11_legacy304
  • linuxPackages_zen.phc-intel
  • linuxPackages_zen.rtl8723bs
  • linuxPackages_zen.sch_cake
  • linuxPackages_zen.tbs
22 packages failed to build:
  • linuxPackages_zen.akvcam
  • linuxPackages_zen.amdgpu-pro
  • linuxPackages_zen.anbox
  • linuxPackages_zen.chipsec
  • linuxPackages_zen.cryptodev
  • linuxPackages_zen.dpdk
  • linuxPackages_zen.ena
  • linuxPackages_zen.mwprocapture
  • linuxPackages_zen.mxu11x0
  • linuxPackages_zen.nvidia_x11_legacy340
  • linuxPackages_zen.nvidia_x11_legacy390
  • linuxPackages_zen.oci-seccomp-bpf-hook
  • linuxPackages_zen.rtl8192eu
  • linuxPackages_zen.rtl8812au
  • linuxPackages_zen.rtl8814au
  • linuxPackages_zen.rtl8821au
  • linuxPackages_zen.rtl8821ce
  • linuxPackages_zen.rtl88x2bu
  • linuxPackages_zen.rtl88xxau-aircrack
  • linuxPackages_zen.rtlwifi_new
  • linuxPackages_zen.virtualbox
  • linuxPackages_zen.virtualboxGuestAdditions
51 packages built:
  • linuxPackages_zen.acpi_call
  • linuxPackages_zen.asus-wmi-sensors
  • linuxPackages_zen.batman_adv
  • linuxPackages_zen.bbswitch
  • linuxPackages_zen.bcc
  • linuxPackages_zen.bpftrace
  • linuxPackages_zen.broadcom_sta
  • linuxPackages_zen.can-isotp
  • linuxPackages_zen.cpupower
  • linuxPackages_zen.ddcci-driver
  • linuxPackages_zen.digimend
  • linuxPackages_zen.evdi
  • linuxPackages_zen.facetimehd
  • linuxPackages_zen.fwts-efi-runtime
  • linuxPackages_zen.gcadapter-oc-kmod
  • linuxPackages_zen.hyperv-daemons
  • linuxPackages_zen.intel-speed-select
  • linuxPackages_zen.it87
  • linuxPackages_zen.jool
  • linux_zen (linuxPackages_zen.kernel)
  • linuxPackages_zen.mba6x_bl
  • linuxPackages_zen.netatop
  • linuxPackages_zen.nvidia_x11
  • linuxPackages_zen.nvidia_x11_beta
  • linuxPackages_zen.nvidia_x11_vulkan_beta
  • linuxPackages_zen.nvidiabl
  • linuxPackages_zen.openafs (linuxPackages_zen.openafs_1_8)
  • linuxPackages_zen.openafs_1_9
  • linuxPackages_zen.openrazer
  • linuxPackages_zen.perf
  • linuxPackages_zen.ply
  • linuxPackages_zen.r8125
  • linuxPackages_zen.r8168
  • linuxPackages_zen.rtl8821cu
  • linuxPackages_zen.sysdig
  • linuxPackages_zen.system76
  • linuxPackages_zen.system76-acpi
  • linuxPackages_zen.system76-io
  • linuxPackages_zen.systemtap
  • linuxPackages_zen.tmon
  • linuxPackages_zen.tp_smapi
  • linuxPackages_zen.turbostat
  • linuxPackages_zen.tuxedo-keyboard
  • linuxPackages_zen.usbip
  • linuxPackages_zen.v4l2loopback
  • linuxPackages_zen.v86d
  • linuxPackages_zen.vhba
  • linuxPackages_zen.x86_energy_perf_policy
  • linuxPackages_zen.xpadneo
  • linuxPackages_zen.zenpower
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable ,linuxPackages_zen.zfsUnstable)

Code-wise looks ok, didn't really tested the kernel but it is a simple enough version bump.

I imagine the module failures are expected?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/322

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108239 run on x86_64-linux 1

8 packages marked as broken and skipped:
22 packages failed to build:
51 packages built:

Can we disable the module that do not build? This would make subsequent updates easier if they build failure count would be not 22.

@Atemu
Copy link
Member

Atemu commented Jan 3, 2021

I've been wanting to write something which checks for mislabeled modules (or packages in general?) but haven't found the time. You could check semi-manually though if you really want to see this improved. See #102209 which did that for 20.09.

@andresilva
Copy link
Member Author

/marvin opt-in
/status needs_merger

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 4, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 4, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 4, 2021

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@thiagokokada
Copy link
Contributor

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from kevincox January 4, 2021 23:33
@Atemu Atemu mentioned this pull request Jan 7, 2021
10 tasks
@SuperSandro2000
Copy link
Member

Replaced by #108688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants