Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dasel: 1.11.0 -> 1.12.0 #108229

Merged
merged 1 commit into from Jan 3, 2021
Merged

dasel: 1.11.0 -> 1.12.0 #108229

merged 1 commit into from Jan 3, 2021

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Jan 2, 2021

Motivation for this change

Upgrade to 1.12.0.

Added

  • Add -c, --compact flag to remove pretty-print formatting from JSON output.
  • Defined storage.IndentOption(indent string) ReadWriteOption.
  • Defined storage.PrettyPrintOption(enabled bool) ReadWriteOption.

Changed

  • Changed storage.Parser funcs to allow the passing of ...ReadWriteOption.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit January 2, 2021 15:47
@WolfangAukang
Copy link
Contributor

WolfangAukang commented Jan 2, 2021 •
edited

Result of nixpkgs-review pr 108229 run on x86_64-linux 1

1 package built:
  • dasel

Working fine and code LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/321

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 108229 1

1 package built:
  • dasel

thiagokokada
thiagokokada approved these changes Jan 2, 2021
View reviewed changes
pkgs/applications/misc/dasel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/dasel/default.nix Outdated Show resolved Hide resolved
@0x4A6F
dasel: 1.11.0 -> 1.12.0
a500ff1 
Added
- Add -c, --compact flag to remove pretty-print formatting from JSON output.
- Defined storage.IndentOption(indent string) ReadWriteOption.
- Defined storage.PrettyPrintOption(enabled bool) ReadWriteOption.

Changed
- Changed storage.Parser funcs to allow the passing of ...ReadWriteOption.
@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 108229 1

1 package built:
  • dasel

@symphorien symphorien merged commit dfd8024 into NixOS:master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@WolfangAukang WolfangAukang WolfangAukang approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@0x4A6F @WolfangAukang @nixos-discourse @thiagokokada @symphorien