Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adminer: Clean up #108230

Merged
merged 1 commit into from Jan 3, 2021
Merged

adminer: Clean up #108230

merged 1 commit into from Jan 3, 2021

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jan 2, 2021 •
edited

Motivation for this change

- Drop unused arguments.

  • Do not use both php and phpPackages since those can have different PHP versions.
  • Do not use with statement just for a single composer package.
  • Add phase hooks so that one can easily customize the derivation.
  • Clarify license to gpl-2.0-only.
  • Add jtojnar to maintainers.

cc @haskelious
Also your github handle is out of date:

nixpkgs/maintainers/maintainer-list.nix

Line 8504 in d47eae3

github = "fkstef";

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
adminer: Clean up
3af8f7c 
- Drop unused arguments.
- Do not use both php and phpPackages since those can have different PHP versions.
- Do not use with statement just for a single composer package.
- Add phase hooks so that one can easily customize the derivation.
- Clarify license to gpl-2.0-only.
- Add jtojnar to maintainers.
@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 2, 2021 •
edited

Result of nixpkgs-review pr 108230 1

1 package built:
  • adminer

Don't know how to really test this, but code-wise looks good and it builds.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/322

@SuperSandro2000 SuperSandro2000 merged commit 63bc270 into NixOS:master Jan 3, 2021
@jtojnar jtojnar deleted the adminer-cleanup branch May 18, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @thiagokokada @nixos-discourse @SuperSandro2000