Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geogebra: 5-0-609-0 → 5-0-620-0, geogebra6: 6-0-609-0 → 6-0-620-0 #108172

Merged
merged 1 commit into from Jan 29, 2021

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jan 1, 2021

Motivation for this change
  • update
  • add web.archive.org urls (old version is not available after new version is released)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding yourself as a maintainer? I know @Ma27 wants to step down.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or torch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108172 run on x86_64-linux 1

2 packages built:
  • geogebra
  • geogebra6

Copy link
Contributor

@voidIess voidIess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

geogebra6 worked for me under nixos. However I have no darvin system laying around. When I tested darwin originally there were some Problems with window focus.

@SuperSandro2000
Copy link
Member

@sikimir please fix the merge conflict.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108172 run on x86_64-darwin 1

2 packages built:
  • geogebra
  • geogebra6

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108172 run on x86_64-linux 1

2 packages built:
  • geogebra
  • geogebra6

@SuperSandro2000 SuperSandro2000 merged commit d17f76f into NixOS:master Jan 29, 2021
@sikmir sikmir deleted the geogebra branch January 29, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants