Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-json-exporter: unstable-2017-10-06 -> 0.2.0 #108179

Merged
merged 3 commits into from Jan 3, 2021
Merged

prometheus-json-exporter: unstable-2017-10-06 -> 0.2.0 #108179

merged 3 commits into from Jan 3, 2021

Conversation

WilliButz
Copy link
Member

Motivation for this change

#107587

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

fixes #107587

@WilliButz WilliButz force-pushed the update/prometheus-json-exporter/0.2.0 branch from 0cf678e to 11d2720 Compare January 1, 2021 23:12
@ofborg ofborg bot requested a review from kalbasit January 1, 2021 23:22
lukegb
lukegb requested changes Jan 2, 2021
View reviewed changes
nixos/tests/prometheus-exporters.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108179 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • prometheus-json-exporter

@WilliButz WilliButz force-pushed the update/prometheus-json-exporter/0.2.0 branch from 11d2720 to 3f94c66 Compare January 2, 2021 12:10
@Ma27
nixos/prometheus-exporters: minor doc improvements
6e43cc7 
* Content of `programlisting` shouldn't be indented, otherwise it's
  weirdly indented in the output.
* Use `<xref linkend=.../>` in the release notes: then users can
  directly go to the option documentation when reading release notes.
* Don't use docbook tags in `mkRemovedOptionModule`: it's only used
  during evaluation where docbook isn't rendered.
@Ma27 Ma27 merged commit 3b57908 into NixOS:master Jan 3, 2021
@WilliButz WilliButz deleted the update/prometheus-json-exporter/0.2.0 branch January 3, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb requested changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prometheus-json-exporter: unstable-2017-10-06 -> 0.2.0
4 participants
@WilliButz @SuperSandro2000 @lukegb @Ma27