bowtie2: 2.3.5.1 -> 2.4.2 #108251
bowtie2: 2.3.5.1 -> 2.4.2 #108251
Conversation
| }; | ||
|
|
||
| buildInputs = [ zlib tbb python perl ]; | ||
| buildInputs = [ zlib tbb python3 perl ]; |
There was a problem hiding this comment.
I think python3 could be a nativeBuilInputs. Not sure about perl.
Maybe we should think about using CMake because the project supports it.
There was a problem hiding this comment.
cmake support added in 9139eb5
I also removed perl/python from the commit, because it was not used during the build
|
@GrahamcOfBorg build bowtie2 |
There was a problem hiding this comment.
LGTM.
$ nixpkgs-review pr 108251
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/108251/head:refs/nixpkgs-review/1
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Total 8 (delta 6), reused 6 (delta 6), pack-reused 2
Unpacking objects: 100% (8/8), 755 bytes | 755.00 KiB/s, done.
From ssh://github.com/NixOS/nixpkgs
+ 2e7ccd2c2c9...9139eb5aeeb refs/pull/108251/head -> refs/nixpkgs-review/1 (forced update)
$ git worktree add /home/matt/.cache/nixpkgs-review/pr-108251/nixpkgs 712830d101d94ae29a2310d91b4d54c0132f5716
Preparing worktree (detached HEAD 712830d101d)
HEAD is now at 712830d101d Merge pull request #108310 from mdlayher/mdl-bump-corerad
$ git merge --no-commit 9139eb5aeeb11cd3bce46f8c8a4984698331b56e
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/matt/.cache/nixpkgs-review/pr-108251/build.nix
[3 built, 1 copied (2.3 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/108251
1 package built:
bowtie2
$ nix-shell /home/matt/.cache/nixpkgs-review/pr-108251/shell.nix
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)