Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.Pyro4: Fix tests on darwin #108253

Merged
merged 1 commit into from Jan 2, 2021
Merged

python3Packages.Pyro4: Fix tests on darwin #108253

merged 1 commit into from Jan 2, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 2, 2021
@ofborg ofborg bot requested a review from prusnak January 2, 2021 19:39
@SuperSandro2000 SuperSandro2000 changed the title python3Packages.pyro4: Fix tests on darwin python3Packages.Pyro4: Fix tests on darwin Jan 2, 2021
@bhipple
Copy link
Contributor

bhipple commented Jan 2, 2021

Result of nixpkgs-review pr 108253 1

@bhipple bhipple merged commit 92a391c into NixOS:master Jan 2, 2021
@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jan 2, 2021 •
edited

This wasn't actually ready as the nixpkgs-review still hangs.

Going to do another PR which fixes the hang.

@SuperSandro2000 SuperSandro2000 deleted the pyro3-darwin branch January 2, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @bhipple @prusnak