Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idris2: 0.2.1 -> 0.2.2 #108266

Merged
merged 1 commit into from Jan 4, 2021
Merged

idris2: 0.2.1 -> 0.2.2 #108266

merged 1 commit into from Jan 4, 2021

Conversation

jumper149
Copy link
Contributor

Motivation for this change

There is a new idris2 release.

Things done

Just updated the source for the derivation.
There don't seem to be any changes breaking compilation.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (didn't test extensively, but REPL seems to work fine at least)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date (there is none)
  • Fits CONTRIBUTING.md.

cc @wchresta

Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message should read:

idris2: 0.2.1 -> 0.2.2

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 3, 2021

Result of nixpkgs-review pr 108266 1

1 package built:
  • idris2

LGTM code-wise, tested REPL and seems to work fine.

@SuperSandro2000 SuperSandro2000 changed the title idris2: update to v0.2.2 idris2: 0.2.1 -> 0.2.2 Jan 3, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108266 run on x86_64-linux 1

1 package built:
  • idris2

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108266 run on x86_64-darwin 1

1 package built:
  • idris2

@SuperSandro2000 SuperSandro2000 merged commit 80677f3 into NixOS:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants