Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 8.3 pill #166

Closed
wants to merge 1 commit into from
Closed

Fix 8.3 pill #166

wants to merge 1 commit into from

Conversation

k4leg
Copy link

@k4leg k4leg commented Jan 2, 2021

Otherwise /nix/store/86k2z0mc023y9qxn8gln4a6kj2a759gx-builder.sh: line 7: tar: No such file or directory.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 2, 2021

It is left as excercise:

Exercise: Complete the new builder.sh by adding $baseInputs in the for loop together with $buildInputs . As you noticed, we passed that new variable in the derivation. Instead of merging buildInputs with the base ones, we prefer to preserve buildInputs as seen by the caller, so we keep them separated. Just a matter of choice.

@k4leg
Copy link
Author

k4leg commented Jan 2, 2021

It is left as excercise:

Exercise: Complete the new builder.sh by adding $baseInputs in the for loop together with $buildInputs . As you noticed, we passed that new variable in the derivation. Instead of merging buildInputs with the base ones, we prefer to preserve buildInputs as seen by the caller, so we keep them separated. Just a matter of choice.

Sorry, I didn't notice.

@k4leg k4leg closed this Jan 2, 2021
@k4leg k4leg deleted the fix-8.3-pill branch January 2, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k4leg @jtojnar