Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: use gcc9 for aarch64 #108200

Merged
merged 1 commit into from Jan 2, 2021
Merged

stdenv: use gcc9 for aarch64 #108200

merged 1 commit into from Jan 2, 2021

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 2, 2021

Several aarch64 builds fail with is referenced by DSO followed by
bin/ld: final link failed: bad value. This seems related to libgcc_s.so.

#108111

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
stdenv: use gcc9 for aarch64
427fbef 
Several aarch64 builds fail with is referenced by DSO followed by
bin/ld: final link failed: bad value. This seems related to libgcc_s.so.

NixOS#108111
@FRidh
Copy link
Member Author

FRidh commented Jan 2, 2021

@GrahamcOfBorg build stdenv

@FRidh
Copy link
Member Author

FRidh commented Jan 2, 2021

@flokli you have access to an aarch64 machine right? Could you test this change a bit?

@ofborg ofborg bot requested review from np, edolstra, lovek323 and andir January 2, 2021 08:11
@FRidh
Copy link
Member Author

FRidh commented Jan 2, 2021

Let's see how this turns out.

@FRidh FRidh merged commit 22f1c74 into NixOS:staging-next Jan 2, 2021
@flokli
Copy link
Contributor

flokli commented Jan 2, 2021

@flokli you have access to an aarch64 machine right? Could you test this change a bit?

Nah, it's not powerful enough to build huge rebuilds. We could have tested on the community builder, though ;-)

@FRidh FRidh deleted the stdenv branch January 2, 2021 11:02
@edolstra
Copy link
Member

edolstra commented Jan 4, 2021

I think using a different gcc for different architectures is a bad idea, guaranteed to cause lots of confusion. Maybe we should just stick to GCC 9 for now.

@FRidh
Copy link
Member Author

FRidh commented Jan 4, 2021 •
edited

Definitely not ideal, but this needs to be resolved for 21.03. Users/maintainers of other platforms need to step up as well.

#108305

@symphorien symphorien mentioned this pull request Jan 6, 2021
Merged
10 tasks
@ghost ghost mentioned this pull request Jan 7, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@np np Awaiting requested review from np

@edolstra edolstra Awaiting requested review from edolstra

@lovek323 lovek323 Awaiting requested review from lovek323

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @flokli @edolstra