Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.reflink: init at 0.2.1 #108203

Merged
merged 1 commit into from Jan 2, 2021
Merged

pythonPackages.reflink: init at 0.2.1 #108203

merged 1 commit into from Jan 2, 2021

Conversation

lovesegfault
Copy link
Member

Motivation for this change

Beets 1.5.0 will need this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Jan 2, 2021
View reviewed changes
pkgs/development/python-modules/reflink/default.nix
sha256 = "sha256-ySU1gtskQTv9cDq/wbKkneePMbSQcjnyhumhkpoebjo=";
};

propagatedBuildInputs = [ cffi pytestrunner ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytestrunner is probably only a installInputs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too, but remove it from propagatedBuildInputs and the package doesn't build, for some reason.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or torch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108203 run on x86_64-linux 1

3 packages built:
  • python37Packages.reflink
  • python38Packages.reflink
  • python39Packages.reflink

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108203 run on x86_64-darwin 1

3 packages built:
  • python37Packages.reflink
  • python38Packages.reflink
  • python39Packages.reflink

@lovesegfault
Copy link
Member Author

Result of nixpkgs-review pr 108203 run on x86_64-linux 1

3 packages built:
  • python37Packages.reflink
  • python38Packages.reflink
  • python39Packages.reflink

@flokli flokli merged commit 4edcaab into NixOS:master Jan 2, 2021
@lovesegfault lovesegfault deleted the pythonPackages.reflink branch January 2, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @SuperSandro2000 @flokli