Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jc: 1.13.4 -> 1.14.0 #108257

Merged
merged 1 commit into from Jan 3, 2021
Merged

jc: 1.13.4 -> 1.14.0 #108257

merged 1 commit into from Jan 3, 2021

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jan 2, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108257 run on x86_64-linux 1

3 packages built:
  • jc (python38Packages.jc)
  • python37Packages.jc
  • python39Packages.jc

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108257 run on x86_64-darwin 1

3 packages built:
  • jc (python38Packages.jc)
  • python37Packages.jc
  • python39Packages.jc

@SuperSandro2000 SuperSandro2000 merged commit b33eada into NixOS:master Jan 3, 2021
@Atemu Atemu deleted the update/jc branch January 3, 2021 09:21
@Atemu
Copy link
Member Author

Atemu commented Jan 3, 2021

@SuperSandro2000 I really appreciate the auto-nixpkgs-review but it's a bit verbose IMO. Might be better to group your automated replies into one comment for all platforms and only add a link to an explanation.

Even better would be an optional GitHub actions check like ofBorg's if that's possible.

Thank you!

@SuperSandro2000
Copy link
Member

Might be better to group your automated replies into one comment for all platforms

I have no idea how to easily to this when the command is run on two machines. I would need to parse the comments and edit one. Sounds a bit tricky.

and only add a link to an explanation.

I can probably remove some of the explanations when I finalized the readme in the repo.

Even better would be an optional GitHub actions check like ofBorg's if that's possible.

Github actions are nice if you run Shellcheck over your code but not when you done a gigabyte repo which takes 3 minutes and then build up to a hundred packages. Also the free tier is probably not enough for my usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants