Skip to content

mpd-small: remove mad from features #108232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2021
Merged

mpd-small: remove mad from features #108232

merged 1 commit into from
Jan 2, 2021
+1 −1

Conversation

CamilleScholtz
Copy link
Contributor

Motivation for this change

This feature already gets enabled when the environment is not darwin (see line 202), having it also it in the 'standard features' breaks the build for darwin currently and seems to be a mistake. I just started using nix yesterday so I don't really know how to run all these tests and things, however it is a fairly small change and builds well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@CamilleScholtz
mpd-small: remove mad from features

Verified

This commit was signed with the committer’s verified signature.
SuperSandro2000 Sandro
GPG key ID: 3AF5A43A3EECC2E5
Verified
Learn about vigilant mode
05f93d4 
this feature already gets enabled when the environment is not darwin (see line 202), keeping it in the 'standard features' breaks the build for darwin currently.
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 2, 2021
@ofborg ofborg bot requested review from astsmtl, ehmry, tobim and fpletz January 2, 2021 16:00
@prusnak
Copy link
Member

prusnak commented Jan 2, 2021

LGTM

comment on line 95 mentions that using mad on darwin causes segfault, so this only looks good

@prusnak prusnak merged commit b97d7ee into NixOS:master Jan 2, 2021
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry

@tobim tobim

@astsmtl astsmtl

@fpletz fpletz

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CamilleScholtz @prusnak @Janik-Haag