Add: always set PERSONAL_DIR "/content_download" in search path #8481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7311.
Motivation / Problem
I am often annoyed during development that the
content_download
folder is only on the search-path once, and this is for the location it foundopenttd.cfg
(or with XDG, this can be~/.local/share/openttd/content_download
. This means that from time to time I get the popup it cannot find my OpenGFX, as I downloaded it via the content service. I have to move it tobaseset
folder in myPERSONAL_DIR
to not have this happening.When does this popup happen? When using
-c
or when running the regression, mostly. I can imagine server-owners have similar experience.There have been bugs reported about this, in all forms. The one that I could find that was still open is #7311.
Description
This means that if you start OpenTTD with "-c" to indicate another
location to store files, it can still read the content you already
downloaded from your PERSONAL_DIR. This folder is, however,
read-only.
This is useful for situations where you downloaded OpenGFX via
the content-service, but want to run the regression or want to
run with a clean configuration. With this change, you no longer
need to download OpenGFX again.
Limitations
content_download
. So thePERSONAL_DIR
really was the only one missing here.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.