Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyarlo: init at 0.2.4 #108236

Closed
wants to merge 1 commit into from
Closed

python3Packages.pyarlo: init at 0.2.4 #108236

wants to merge 1 commit into from

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 2, 2021

Motivation for this change

Python Arlo is a library written in Python 2.7/3x that exposes the Netgear Arlo cameras as Python objects.

https://github.com/tchellomello/python-arlo

This is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Jan 2, 2021

Result of nixpkgs-review pr 108236 1

3 packages built:
  • python37Packages.pyarlo
  • python38Packages.pyarlo
  • python39Packages.pyarlo

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108236 run on x86_64-darwin 1

3 packages built:
  • python37Packages.pyarlo
  • python38Packages.pyarlo
  • python39Packages.pyarlo

mweinelt
mweinelt requested changes Jan 4, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fetch the sources from GitHub so we can have tests.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108236 run on x86_64-linux 1

3 packages built:
  • python37Packages.pyarlo
  • python38Packages.pyarlo
  • python39Packages.pyarlo

@mweinelt
Copy link
Member

mweinelt commented Jan 5, 2021

Result of nixpkgs-review pr 108236 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python39Packages.pyarlo
2 packages built:
  • python37Packages.pyarlo
  • python38Packages.pyarlo

Fails on Python 3.9 because python39Packages.fixtures is marked as broken.

mweinelt
mweinelt requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed the component-packages.nix change after force-pushing.

@Mic92
Copy link
Member

Mic92 commented Jan 6, 2021

@mweinelt maybe you can cherry-pick to #108602 to re-generate component-packages.nix to avoid merge conflicts?

@mweinelt
Copy link
Member

mweinelt commented Jan 6, 2021

Yep, done. Thanks for the poke.

@mweinelt mweinelt closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabaff @SuperSandro2000 @mweinelt @Mic92