Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combined nodePackages update and init #108235

Merged
merged 8 commits into from Jan 3, 2021
Merged

Combined nodePackages update and init #108235

merged 8 commits into from Jan 3, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#107200 #107168 #106665 #94945 #73119 #108178 #100540

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member Author

Now doing the update and merging when it is done before we get a thousand new merge conflicts.

@SuperSandro2000 SuperSandro2000 force-pushed the mass-node-packages branch 2 times, most recently from a2346a8 to fab7ac9 Compare January 2, 2021 17:01
@SuperSandro2000
Copy link
Member Author

Only took 71m 38s to generate.

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review January 2, 2021 19:17
@ofborg ofborg bot requested a review from midchildan January 2, 2021 19:25
@SuperSandro2000 SuperSandro2000 merged commit ada3931 into NixOS:master Jan 3, 2021
@SuperSandro2000 SuperSandro2000 deleted the mass-node-packages branch January 3, 2021 08:15
@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jan 3, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108235 run on x86_64-linux 1

1 package failed to build and are new build failure:
15 packages built:
  • antora
  • bitwarden-cli
  • castnow
  • create-cycle-app
  • epgstation
  • fast-cli
  • joplin
  • mastodon-bot
  • mirakurun
  • netlify-cli
  • shout
  • vimPlugins.coc-go
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-vetur
  • vscode-extensions.matklad.rust-analyzer

@FRidh
Copy link
Member

FRidh commented Jan 3, 2021

I think there is a node-related evaluation error #108304.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 10, 2021
Closed
10 tasks
@jlesquembre jlesquembre mentioned this pull request Jan 20, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midchildan midchildan Awaiting requested review from midchildan

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @FRidh @kira-bruneau