Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron: fix tray icon in wayland #108208

Merged
merged 1 commit into from Jan 2, 2021
Merged

electron: fix tray icon in wayland #108208

merged 1 commit into from Jan 2, 2021

Conversation

Kazimazi
Copy link
Contributor

@Kazimazi Kazimazi commented Jan 2, 2021 •
edited

Motivation for this change
  • Element-desktop icon wasn't showing in the tray bar on wayland.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak requested changes Jan 2, 2021
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change commit message to:

electron: fix tray icon in wayland

@Kazimazi Kazimazi changed the title element-desktop: fix tray icon in wayland electron: fix tray icon in wayland Jan 2, 2021
@ofborg ofborg bot requested a review from prusnak January 2, 2021 11:40
@prusnak prusnak merged commit 0224ebf into NixOS:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru Awaiting requested review from manveru

@travisbhartwell travisbhartwell Awaiting requested review from travisbhartwell

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kazimazi @prusnak @Janik-Haag