Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.xml2rfc: Fix dependencies #108210

Merged
merged 1 commit into from Jan 2, 2021
Merged

pythonPackages.xml2rfc: Fix dependencies #108210

merged 1 commit into from Jan 2, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from yrashk and vcunat January 2, 2021 10:38
@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or torch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108210 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • python39Packages.xml2rfc
2 packages built:
  • python37Packages.xml2rfc
  • xml2rfc (python38Packages.xml2rfc)

@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or torch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108210 run on x86_64-linux 1

2 packages built:
  • python37Packages.xml2rfc
  • xml2rfc (python38Packages.xml2rfc)

@SuperSandro2000 SuperSandro2000 merged commit 82dcbdf into NixOS:master Jan 2, 2021
@SuperSandro2000 SuperSandro2000 deleted the xml2rfc branch January 4, 2021 07:21
dotlambda
dotlambda reviewed Jun 29, 2021
View reviewed changes
pkgs/development/python-modules/xml2rfc/default.nix
}:

buildPythonPackage rec {
pname = "xml2rfc";
version = "3.5.0";
disabled = pythonAtLeast "3.9";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 Do you remember why you set this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't remember.

Probably because it failed to build at the time

1 package failed to build and are new build failure:
python39Packages.xml2rfc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@yrashk yrashk Awaiting requested review from yrashk

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @dotlambda