Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused: init at 0.2.0 #107143

Closed
wants to merge 1 commit into from
Closed

Conversation

matthiasbeyer
Copy link
Contributor

Closes #107074

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@@ -0,0 +1,28 @@
{ rustPlatform, fetchFromGitHub, lib, stdenv
, pkgconfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, pkgconfig
, pkg-config


cargoSha256 = "1scs4yjf70k54i94d520xkd1q4wbqfcs5048j7zhiphmkykx22br";

meta = with lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with lib; {
meta = with stdenv.lib; {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this serious?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I pasted something from my clipboard here. Meant to be stdenv.

sha256 = "0ympdwqv9l66cn1cmg7g2d1rsq34a2bp5yv22ljr859hbk3w1jbq";
};

nativeBuildInputs = [ pkgconfig cmake ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [ pkgconfig cmake ];
nativeBuildInputs = [ cmake pkg-config ];

@@ -0,0 +1,28 @@
{ rustPlatform, fetchFromGitHub, lib, stdenv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ rustPlatform, fetchFromGitHub, lib, stdenv
{ rustPlatform, fetchFromGitHub, stdenv

@marsam
Copy link
Contributor

marsam commented Dec 19, 2020

Duplicate of #107077

@marsam marsam marked this as a duplicate of #107077 Dec 19, 2020
@matthiasbeyer matthiasbeyer deleted the init-unused branch December 19, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unused 0.1.0
3 participants