Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocm: 3.10.0 -> 4.0.0 #107136

Merged
merged 9 commits into from Dec 21, 2020
Merged

rocm: 3.10.0 -> 4.0.0 #107136

merged 9 commits into from Dec 21, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Dec 18, 2020 •
edited

Motivation for this change

Updates the rocm stack from 3.10.0 to 4.0.0.

Please do not merge without approval from both @acowley and @Flakebi .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 changed the title Update ROCm to 4.0.0 llvmPackages_rocm: 3.10.0 -> 4.0.0 Dec 18, 2020
@SuperSandro2000
Copy link
Member

I've changed the PR title to be more easily searchable.

@danieldk danieldk changed the title llvmPackages_rocm: 3.10.0 -> 4.0.0 rocm: 3.10.0 -> 4.0.0 Dec 18, 2020
@danieldk
Copy link
Contributor Author

I've changed the PR title to be more easily searchable.

Changed again, because the updated title suggests that this PR only modifies one package. If anything, the important package is rocm-opencl-runtime or rocm-opencl-icd.

@danieldk
rocm-runtime: 3.10.0 -> 4.0.0
edfcf08 
No changes compared to the previous release.
@danieldk
rocm-comgr: 3.10.0 -> 4.0.0
240416a 
No changes compared to the previous release.
@danieldk
rocm-cmake: 3.10.0 -> 4.0.0
03e8a2f 
No changes compared to the previous release.
@danieldk
rocclr: 3.10.0 -> 4.0.0
39fefb9
@danieldk
rocm-opencl-runtime: 3.10.0 -> 4.0.0
78ca64c 
No changes compared to the previous release.
@danieldk
rocm-smi: 3.10.0 -> 4.0.0
3cdb918 
No changes compared to the previous release.
@danieldk danieldk marked this pull request as ready for review December 19, 2020 07:01
Flakebi
Flakebi approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks and works good for me.

acowley
acowley approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@acowley acowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clinfo output looks good to me, and I've updated the overlay including hip.

@danieldk danieldk merged commit 86477da into NixOS:master Dec 21, 2020
@danieldk danieldk deleted the rocm-4.0.0 branch December 21, 2020 21:05
@danieldk
Copy link
Contributor Author

Thanks for the reviews!

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107136 run on x86_64-linux 1

9 packages built:
  • rocclr
  • rocm-cmake
  • rocm-comgr
  • rocm-device-libs
  • rocm-opencl-icd
  • rocm-opencl-runtime
  • rocm-runtime
  • rocm-smi
  • rocm-thunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acowley acowley acowley approved these changes

@Flakebi Flakebi Flakebi approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @SuperSandro2000 @acowley @Flakebi