linux_lqx: init at 5.9.15 #107148

Atemu · 2020-12-18T11:58:24Z

Motivation for this change

Same source as linux_zen but not quite as bleeding edge and stays on an older
version for longer (e.g. currenly on the newest 5.9 release while linux_zen is
already on 5.10)

Things done

Result of nixpkgs-review pr 107148 run on x86_64-linux 1

8 packages marked as broken and skipped:

linuxPackages_lqx.ixgbevf
linuxPackages_lqx.lttng-modules
linuxPackages_lqx.ndiswrapper
linuxPackages_lqx.nvidia_x11_legacy304
linuxPackages_lqx.phc-intel
linuxPackages_lqx.rtl8723bs
linuxPackages_lqx.sch_cake
linuxPackages_lqx.tbs

17 packages failed to build:

linuxPackages_lqx.amdgpu-pro
linuxPackages_lqx.anbox
linuxPackages_lqx.ati_drivers_x11
linuxPackages_lqx.broadcom_sta
linuxPackages_lqx.chipsec
linuxPackages_lqx.cryptodev
linuxPackages_lqx.dpdk
linuxPackages_lqx.evdi
linuxPackages_lqx.mwprocapture
linuxPackages_lqx.mxu11x0
linuxPackages_lqx.nvidia_x11_legacy340
linuxPackages_lqx.nvidia_x11_legacy390
linuxPackages_lqx.oci-seccomp-bpf-hook
linuxPackages_lqx.rtl8814au
linuxPackages_lqx.rtl8821au
linuxPackages_lqx.rtl88xxau-aircrack
linuxPackages_lqx.rtlwifi_new

56 packages built:

linuxPackages_lqx.acpi_call
linuxPackages_lqx.akvcam
linuxPackages_lqx.asus-wmi-sensors
linuxPackages_lqx.batman_adv
linuxPackages_lqx.bbswitch
linuxPackages_lqx.bcc
linuxPackages_lqx.bpftrace
linuxPackages_lqx.can-isotp
linuxPackages_lqx.cpupower
linuxPackages_lqx.ddcci-driver
linuxPackages_lqx.digimend
linuxPackages_lqx.ena
linuxPackages_lqx.facetimehd
linuxPackages_lqx.fwts-efi-runtime
linuxPackages_lqx.gcadapter-oc-kmod
linuxPackages_lqx.hyperv-daemons
linuxPackages_lqx.intel-speed-select
linuxPackages_lqx.it87
linuxPackages_lqx.jool
linuxPackages_lqx.kernel
linuxPackages_lqx.mba6x_bl
linuxPackages_lqx.netatop
linuxPackages_lqx.nvidia_x11
linuxPackages_lqx.nvidia_x11_vulkan_beta
linuxPackages_lqx.nvidiabl
linuxPackages_lqx.openafs
linuxPackages_lqx.openafs_1_9
linuxPackages_lqx.openrazer
linuxPackages_lqx.perf
linuxPackages_lqx.ply
linuxPackages_lqx.r8125
linuxPackages_lqx.r8168
linuxPackages_lqx.rtl8192eu
linuxPackages_lqx.rtl8812au
linuxPackages_lqx.rtl8821ce
linuxPackages_lqx.rtl8821cu
linuxPackages_lqx.rtl88x2bu
linuxPackages_lqx.sysdig
linuxPackages_lqx.system76
linuxPackages_lqx.system76-acpi
linuxPackages_lqx.system76-io
linuxPackages_lqx.systemtap
linuxPackages_lqx.tmon
linuxPackages_lqx.tp_smapi
linuxPackages_lqx.turbostat
linuxPackages_lqx.tuxedo-keyboard
linuxPackages_lqx.usbip
linuxPackages_lqx.v4l2loopback
linuxPackages_lqx.v86d
linuxPackages_lqx.vhba
linuxPackages_lqx.virtualbox
linuxPackages_lqx.virtualboxGuestAdditions
linuxPackages_lqx.x86_energy_perf_policy
linuxPackages_lqx.xpadneo
linuxPackages_lqx.zenpower
linuxPackages_lqx.zfs (linuxPackages_lqx.zfsUnstable)

cc @andresilva

Atemu · 2020-12-18T12:01:49Z

/marvin opt-in
/status needs_reviewer

marvin-mk2 · 2020-12-18T12:01:51Z

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

Same source as linux_zen but with a release schedule that's not quite as bleeding edge. For example, it's currenly on the newest 5.9 release while linux_zen is already on 5.10 and won't release future 5.9 fixes. Originally meant for debianish Distros.

Atemu · 2020-12-18T12:08:45Z

pkgs/os-specific/linux/kernel/linux-lqx.nix

+buildLinux (args // {
+  modDirVersion = "${version}-lqx1";
+  inherit version;
+  isZen = true;


Same source as zen, so I didn't bother adding isLqx

andresilva · 2020-12-18T12:16:40Z

Result of nixpkgs-review pr 107148 run on x86_64-linux 1

8 packages marked as broken and skipped:

linuxPackages_lqx.ixgbevf
linuxPackages_lqx.lttng-modules
linuxPackages_lqx.ndiswrapper
linuxPackages_lqx.nvidia_x11_legacy304
linuxPackages_lqx.phc-intel
linuxPackages_lqx.rtl8723bs
linuxPackages_lqx.sch_cake
linuxPackages_lqx.tbs

17 packages failed to build:

linuxPackages_lqx.amdgpu-pro
linuxPackages_lqx.anbox
linuxPackages_lqx.ati_drivers_x11
linuxPackages_lqx.broadcom_sta
linuxPackages_lqx.chipsec
linuxPackages_lqx.cryptodev
linuxPackages_lqx.dpdk
linuxPackages_lqx.evdi
linuxPackages_lqx.mwprocapture
linuxPackages_lqx.mxu11x0
linuxPackages_lqx.nvidia_x11_legacy340
linuxPackages_lqx.nvidia_x11_legacy390
linuxPackages_lqx.oci-seccomp-bpf-hook
linuxPackages_lqx.rtl8814au
linuxPackages_lqx.rtl8821au
linuxPackages_lqx.rtl88xxau-aircrack
linuxPackages_lqx.rtlwifi_new

56 packages built:

linuxPackages_lqx.acpi_call
linuxPackages_lqx.akvcam
linuxPackages_lqx.asus-wmi-sensors
linuxPackages_lqx.batman_adv
linuxPackages_lqx.bbswitch
linuxPackages_lqx.bcc
linuxPackages_lqx.bpftrace
linuxPackages_lqx.can-isotp
linuxPackages_lqx.cpupower
linuxPackages_lqx.ddcci-driver
linuxPackages_lqx.digimend
linuxPackages_lqx.ena
linuxPackages_lqx.facetimehd
linuxPackages_lqx.fwts-efi-runtime
linuxPackages_lqx.gcadapter-oc-kmod
linuxPackages_lqx.hyperv-daemons
linuxPackages_lqx.intel-speed-select
linuxPackages_lqx.it87
linuxPackages_lqx.jool
linuxPackages_lqx.kernel
linuxPackages_lqx.mba6x_bl
linuxPackages_lqx.netatop
linuxPackages_lqx.nvidia_x11
linuxPackages_lqx.nvidia_x11_vulkan_beta
linuxPackages_lqx.nvidiabl
linuxPackages_lqx.openafs
linuxPackages_lqx.openafs_1_9
linuxPackages_lqx.openrazer
linuxPackages_lqx.perf
linuxPackages_lqx.ply
linuxPackages_lqx.r8125
linuxPackages_lqx.r8168
linuxPackages_lqx.rtl8192eu
linuxPackages_lqx.rtl8812au
linuxPackages_lqx.rtl8821ce
linuxPackages_lqx.rtl8821cu
linuxPackages_lqx.rtl88x2bu
linuxPackages_lqx.sysdig
linuxPackages_lqx.system76
linuxPackages_lqx.system76-acpi
linuxPackages_lqx.system76-io
linuxPackages_lqx.systemtap
linuxPackages_lqx.tmon
linuxPackages_lqx.tp_smapi
linuxPackages_lqx.turbostat
linuxPackages_lqx.tuxedo-keyboard
linuxPackages_lqx.usbip
linuxPackages_lqx.v4l2loopback
linuxPackages_lqx.v86d
linuxPackages_lqx.vhba
linuxPackages_lqx.virtualbox
linuxPackages_lqx.virtualboxGuestAdditions
linuxPackages_lqx.x86_energy_perf_policy
linuxPackages_lqx.xpadneo
linuxPackages_lqx.zenpower
linuxPackages_lqx.zfs (linuxPackages_lqx.zfsUnstable)

Atemu · 2020-12-22T09:39:22Z

Result of nixpkgs-review pr 107148 run on x86_64-linux 1

8 packages marked as broken and skipped:

linuxPackages_lqx.ixgbevf
linuxPackages_lqx.lttng-modules
linuxPackages_lqx.ndiswrapper
linuxPackages_lqx.nvidia_x11_legacy304
linuxPackages_lqx.phc-intel
linuxPackages_lqx.rtl8723bs
linuxPackages_lqx.sch_cake
linuxPackages_lqx.tbs

15 packages failed to build:

linuxPackages_lqx.amdgpu-pro
linuxPackages_lqx.anbox
linuxPackages_lqx.broadcom_sta
linuxPackages_lqx.chipsec
linuxPackages_lqx.cryptodev
linuxPackages_lqx.dpdk
linuxPackages_lqx.mwprocapture
linuxPackages_lqx.mxu11x0
linuxPackages_lqx.nvidia_x11_legacy340
linuxPackages_lqx.nvidia_x11_legacy390
linuxPackages_lqx.oci-seccomp-bpf-hook
linuxPackages_lqx.rtl8814au
linuxPackages_lqx.rtl8821au
linuxPackages_lqx.rtl88xxau-aircrack
linuxPackages_lqx.rtlwifi_new

61 packages built:

linuxPackages_lqx.acpi_call
linuxPackages_lqx.akvcam
linuxPackages_lqx.asus-wmi-sensors
linuxPackages_lqx.batman_adv
linuxPackages_lqx.bbswitch
linuxPackages_lqx.bcc
linuxPackages_lqx.bpftrace
linuxPackages_lqx.can-isotp
linuxPackages_lqx.cpupower
linuxPackages_lqx.ddcci-driver
linuxPackages_lqx.digimend
linuxPackages_lqx.ena
linuxPackages_lqx.evdi
linuxPackages_lqx.facetimehd
linuxPackages_lqx.fwts-efi-runtime
linuxPackages_lqx.gcadapter-oc-kmod
linuxPackages_lqx.hyperv-daemons
linuxPackages_lqx.intel-speed-select
linuxPackages_lqx.it87
linuxPackages_lqx.jool
linux_lqx (linuxPackages_lqx.kernel)
linuxPackages_lqx.mba6x_bl
linuxPackages_lqx.netatop
linuxPackages_lqx.nvidia_x11
linuxPackages_lqx.nvidia_x11_beta
linuxPackages_lqx.nvidia_x11_vulkan_beta
linuxPackages_lqx.nvidiabl
linuxPackages_lqx.odp-dpdk
linuxPackages_lqx.openafs (linuxPackages_lqx.openafs_1_8)
linuxPackages_lqx.openafs_1_9
linuxPackages_lqx.openrazer
linuxPackages_lqx.perf
linuxPackages_lqx.pktgen
linuxPackages_lqx.ply
linuxPackages_lqx.r8125
linuxPackages_lqx.r8168
linuxPackages_lqx.rtl8192eu
linuxPackages_lqx.rtl8812au
linuxPackages_lqx.rtl8821ce
linuxPackages_lqx.rtl8821cu
linuxPackages_lqx.rtl88x2bu
linuxPackages_lqx.stdenv
linuxPackages_lqx.sysdig
linuxPackages_lqx.system76
linuxPackages_lqx.system76-acpi
linuxPackages_lqx.system76-io
linuxPackages_lqx.systemtap
linuxPackages_lqx.tmon
linuxPackages_lqx.tp_smapi
linuxPackages_lqx.turbostat
linuxPackages_lqx.tuxedo-keyboard
linuxPackages_lqx.usbip
linuxPackages_lqx.v4l2loopback
linuxPackages_lqx.v86d
linuxPackages_lqx.vhba
linuxPackages_lqx.virtualbox
linuxPackages_lqx.virtualboxGuestAdditions
linuxPackages_lqx.x86_energy_perf_policy
linuxPackages_lqx.xpadneo
linuxPackages_lqx.zenpower
linuxPackages_lqx.zfs (linuxPackages_lqx.zfsStable ,linuxPackages_lqx.zfsUnstable)

@timokau I think Marvin got confused. The PR is reviewed and should now be waiting on a merger. Could it be because I "reviewed" my own PR and it therefore didn't catch @andresilva's review? Or do they need to set needs_merger manually?

Btw, you should get your membership fixed @andresilva, I can't even re-request a review from you.

timokau · 2020-12-22T10:01:11Z

Yes, "needs merger" needs to be set explicitly since approval does not mean the same thing for everybody. This is actually a good example: It's clear that @andresilva ran nixpkgs-review on this. The approval may just mean that nixpkgs-review passed, or it may mean that they also read the diff in detail and think this is good for merge ("would do it themselves if they could"). Both are valuable contributions, but unfortunately marvin can't distinguish the two. So the "needs merge" label needs to be explicitly set as a "stronger"/more clearly defined version of approval. I don't like the UX of this very much, but I haven't come up with something much better yet either. I have thought of scanning for the word "merge" in the text of an approving review, maybe that will make it feel a bit more natural.

There's still a bug here though. Marvin set the status to "awaiting changes" after your self review, which it shouldn't do. See timokau/marvin-mk2#104.

pkgs/os-specific/linux/kernel/linux-lqx.nix

andresilva · 2020-12-22T14:26:57Z

Btw, you should get your membership fixed @andresilva, I can't even re-request a review from you.

Sorry for the inconvenience, I already tried to solve this. I was told that there used to be a bot doing this and it was "temporarily" disabled. I asked in Discord about how to deal with the membership manually and didn't get any replies. If anyone reading this comment has any suggestions on that please share :)

timokau · 2020-12-22T15:26:03Z

Sorry for the inconvenience, I already tried to solve this. I was told that there used to be a bot doing this and it was "temporarily" disabled.

For reference: NixOS/rfc39#3

I asked in Discord about how to deal with the membership manually and didn't get any replies. If anyone reading this comment has any suggestions on that please share :)

The bottle-neck for manual membership additions is pretty thin. I think it requires owner permission, which only a handful of people have. I think that is why nobody is doing manual additions of maintainers: It doesn't scale, and if somebody starts to do it they would probably soon receive too many requests. So unfortunately there is not much you can do right now, except wait or contribute to NixOS/rfc39#3.

marvin-mk2 · 2020-12-25T17:19:22Z

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

Taken from https://liquorix.net/ who use the same sauce in their kernel

timokau

Thanks!

flokli · 2020-12-28T20:28:14Z

@andresilva #107815

Atemu · 2020-12-29T05:06:36Z

I'm sure they're aware, they wrote the PR that fixed the bot ;)

Atemu added the 6.topic: kernel label Dec 18, 2020

marvin-mk2 bot added the marvin label Dec 18, 2020

marvin-mk2 bot added the needs_reviewer label Dec 18, 2020

linux_lqx: init at 5.9.15

ff636d5

Same source as linux_zen but with a release schedule that's not quite as bleeding edge. For example, it's currenly on the newest 5.9 release while linux_zen is already on 5.10 and won't release future 5.9 fixes. Originally meant for debianish Distros.

Atemu force-pushed the linux_lqx-init branch from 897337f to ff636d5 Compare December 18, 2020 12:08

Atemu commented Dec 18, 2020

View reviewed changes

marvin-mk2 bot added awaiting_reviewer and removed needs_reviewer labels Dec 18, 2020

andresilva approved these changes Dec 18, 2020

View reviewed changes

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 and removed 6.topic: kernel labels Dec 20, 2020

linux_lqx: 5.9.15 -> 5.9.16

fd2d1eb

timokau mentioned this pull request Dec 22, 2020

Do not transition needs_reviewer -> awaiting_changes on self-review timokau/marvin-mk2#104

Closed

timokau reviewed Dec 22, 2020

View reviewed changes

pkgs/os-specific/linux/kernel/linux-lqx.nix Show resolved Hide resolved

Atemu added 2 commits December 26, 2020 13:30

linux_zen: add a description

02437ff

Taken from https://liquorix.net/ who use the same sauce in their kernel

linux_lqx: add a description

0fdf692

Atemu requested a review from timokau December 26, 2020 12:36

timokau approved these changes Dec 28, 2020

View reviewed changes

timokau merged commit 90d95d4 into NixOS:master Dec 28, 2020

Atemu deleted the linux_lqx-init branch December 29, 2020 05:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linux_lqx: init at 5.9.15 #107148

linux_lqx: init at 5.9.15 #107148

Atemu commented Dec 18, 2020 •

edited

Atemu commented Dec 18, 2020

marvin-mk2 bot commented Dec 18, 2020

Atemu Dec 18, 2020

andresilva commented Dec 18, 2020

Atemu commented Dec 22, 2020

timokau commented Dec 22, 2020

andresilva commented Dec 22, 2020

timokau commented Dec 22, 2020

marvin-mk2 bot commented Dec 25, 2020

timokau left a comment

flokli commented Dec 28, 2020

Atemu commented Dec 29, 2020

linux_lqx: init at 5.9.15 #107148

linux_lqx: init at 5.9.15 #107148

Conversation

Atemu commented Dec 18, 2020 • edited

Motivation for this change

Things done

Atemu commented Dec 18, 2020

marvin-mk2 bot commented Dec 18, 2020

Atemu Dec 18, 2020

Choose a reason for hiding this comment

andresilva commented Dec 18, 2020

Atemu commented Dec 22, 2020

timokau commented Dec 22, 2020

andresilva commented Dec 22, 2020

timokau commented Dec 22, 2020

marvin-mk2 bot commented Dec 25, 2020

timokau left a comment

Choose a reason for hiding this comment

flokli commented Dec 28, 2020

Atemu commented Dec 29, 2020

Atemu commented Dec 18, 2020 •

edited