Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia_x11_beta: 455.45.01 -> 460.27.04 #107150

Merged
merged 1 commit into from Dec 19, 2020
Merged

nvidia_x11_beta: 455.45.01 -> 460.27.04 #107150

merged 1 commit into from Dec 19, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Dec 18, 2020 •
edited

Motivation for this change

#106999
#107105

Closes #107170

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu
Copy link
Member Author

Atemu commented Dec 18, 2020

/marvin opt-in
/status needs_reviewer

cc @timothyklim

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 18, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107150 run on x86_64-linux 1

17 packages built:
  • linuxPackages-libre.nvidia_x11_beta
  • linuxPackages.nvidia_x11_beta
  • linuxPackages_4_14.nvidia_x11_beta
  • linuxPackages_4_19.nvidia_x11_beta
  • linuxPackages_4_4.nvidia_x11_beta
  • linuxPackages_4_9.nvidia_x11_beta
  • linuxPackages_5_10.nvidia_x11_beta
  • linuxPackages_5_9.nvidia_x11_beta
  • linuxPackages_hardened.nvidia_x11_beta
  • linuxPackages_latest-libre.nvidia_x11_beta
  • linuxPackages_latest_hardened.nvidia_x11_beta
  • linuxPackages_latest_xen_dom0.nvidia_x11_beta
  • linuxPackages_latest_xen_dom0_hardened.nvidia_x11_beta
  • linuxPackages_testing_bcachefs.nvidia_x11_beta
  • linuxPackages_xen_dom0.nvidia_x11_beta
  • linuxPackages_xen_dom0_hardened.nvidia_x11_beta
  • linuxPackages_zen.nvidia_x11_beta

@nyanotech nyanotech mentioned this pull request Dec 19, 2020
Closed
10 tasks
@Atemu Atemu requested a review from danieldk December 19, 2020 04:50
danieldk
danieldk approved these changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@danieldk danieldk merged commit a634c41 into NixOS:master Dec 19, 2020
@Atemu Atemu deleted the update/nvidia branch December 19, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@eadwu eadwu Awaiting requested review from eadwu

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Atemu @SuperSandro2000 @danieldk