rofi: Add option to symlink dmenu #107146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
|
Requires a rebase. The previous change added a gappsWrapper which may mess/conflict with the symlink. Should it symlink the wrapped rofi? |
Rofi has the ability to handle input from scripts designed for `dmenu`. As per the documentation, all it's needed to get this working is a symlink: > If argv[0] (calling command) is dmenu, rofi will start in dmenu mode. This way it can be used as a drop-in replacement for dmenu. just copy or symlink rofi to dmenu in $PATH. I'm adding this ability to the Rofi derivation by adding the `symlink-dmenu` bool argument
I've rebased and tested locally and it still works. |
SuperSandro2000
requested changes
Mar 21, 2021
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rofi has the ability to handle input from scripts designed for
dmenu. As per the documentation, all it's needed to get this working is a symlink:I'm adding this ability to the Rofi derivation by adding the
symlink-dmenubool argument