New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: extend the allowed range for max loan setting #8386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor coding style blabla :D
Other than that, I am totally fine with a patch like this.
For the record, I changed tests because for whatever reason max_loan is actually 2000000000 in the test savegame so it wasn't even a valid value before.
|
I did some digging and found f381b91. But still doesn't explain why the value in the savegame is not in the original range. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird old save games be weird
From 100000 - 500000 to 0 - 2000000000.
0 to allow gamescripts do game modes without loan. 2000000000 since it's enough for all forseable reasons and int32 is the max settings gui currently supports (well, it was a bit less but I fixed that). Also fixed gui overflow with iranian rials while at it.